fix: remove MarshalJSON function

Author: wafuwafu13

events/ecs_container_instance.go

@@ -1,9 +1,6 @@
 package events
 
-import (
-	"encoding/json"
-	"time"
-)
+import "time"
 
 type ECSContainerInstanceEvent struct {
 	Version    string                              `json:"version"`
@@ -47,24 +44,3 @@ type ECSContainerInstanceEventVersionInfo struct {
 	AgentVersion  string `json:"agentVersion"`
 	DockerVersion string `json:"dockerVersion"`
 }
-
-// MarshalJSON implements custom marshaling to marshal the struct into JSON format while preserving an empty string slice in `StringSetValue` field.
-func (r ECSContainerInstanceEventResource) MarshalJSON() ([]byte, error) {
-	type Alias ECSContainerInstanceEventResource
-	aux := struct {
-		StringSetValue json.RawMessage `json:"stringSetValue,omitempty"`
-		Alias
-	}{
-		Alias: (Alias)(r),
-	}
-
-	if r.StringSetValue != nil {
-		b, err := json.Marshal(r.StringSetValue)
-		if err != nil {
-			return nil, err
-		}
-		aux.StringSetValue = b
-	}
-
-	return json.Marshal(&aux)
-}

events/ecs_container_instance_test.go

@@ -82,7 +82,26 @@ func TestECSContainerInstanceEventMarshaling(t *testing.T) {
 	}
 
 	// 5. check result
-	assert.JSONEq(t, string(inputJSON), string(outputJSON))
+	// `registeredResources` key and `remainingResources` key have `stringSetValue` key.
+	// if `stringSetValue` key is empty array, it should be removed from outputJSON.
+	var result map[string]interface{}
+	json.Unmarshal(outputJSON, &result)
+	for _, resourcesType := range []string{"registeredResources", "remainingResources"} {
+		resources := result["detail"].(map[string]interface{})[resourcesType].([]interface{})
+		for i, resource := range resources {
+			resourceMap := resource.(map[string]interface{})
+			if _, ok := resourceMap["stringSetValue"]; ok {
+				stringSetValue := resourceMap["stringSetValue"].([]interface{})
+				if len(stringSetValue) == 0 {
+					delete(resourceMap, "stringSetValue")
+					resources[i] = resourceMap
+				}
+			}
+		}
+	}
+	resultJSON, _ := json.Marshal(result)
+
+	assert.JSONEq(t, string(outputJSON), string(resultJSON))
 }
 
 func TestECSContainerInstanceMarshalingMalformedJson(t *testing.T) {