Skip to content

Commit a5adfc6

Browse files
author
Siddharth Yagnik
committed
Nit: Small changes
1 parent 01e15a5 commit a5adfc6

File tree

1 file changed

+2
-6
lines changed

1 file changed

+2
-6
lines changed

src/main/java/software/amazon/msk/auth/iam/internals/MSKCredentialProvider.java

+2-6
Original file line numberDiff line numberDiff line change
@@ -166,9 +166,8 @@ protected AwsCredentialsProvider getDefaultProvider() {
166166

167167
@Override
168168
public AwsCredentials resolveCredentials() {
169-
log.error("RESOLVING CREDENTIALS!!");
170169
AwsCredentials credentials = loadCredentialsWithRetry();
171-
if (credentials != null && shouldDebugCreds) {
170+
if (credentials != null && shouldDebugCreds && log.isDebugEnabled()) {
172171
logCallerIdentity(credentials);
173172
}
174173
return credentials;
@@ -219,7 +218,7 @@ private void logCallerIdentity(AwsCredentials credentials) {
219218
try {
220219
StsClient stsClient = getStsClientForDebuggingCreds(credentials);
221220
GetCallerIdentityResponse response = stsClient.getCallerIdentity();
222-
log.error("The identity of the credentials is {}", response.toString());
221+
log.debug("The identity of the credentials is {}", response.toString());
223222
} catch (Exception e) {
224223
//If we run into an exception logging the caller identity, we should log the exception but
225224
//continue running.
@@ -362,7 +361,6 @@ StsAssumeRoleCredentialsProvider createSTSRoleCredentialProvider(
362361
.build();
363362
return StsAssumeRoleCredentialsProvider.builder()
364363
.stsClient(stsClient)
365-
.asyncCredentialUpdateEnabled(true)
366364
.refreshRequest(roleRequest)
367365
.asyncCredentialUpdateEnabled(true)
368366
.build();
@@ -381,7 +379,6 @@ StsAssumeRoleCredentialsProvider createSTSRoleCredentialProvider(
381379
.build();
382380
return StsAssumeRoleCredentialsProvider.builder()
383381
.stsClient(stsClient)
384-
.asyncCredentialUpdateEnabled(true)
385382
.refreshRequest(roleRequest)
386383
.asyncCredentialUpdateEnabled(true)
387384
.build();
@@ -399,7 +396,6 @@ StsAssumeRoleCredentialsProvider createSTSRoleCredentialProvider(
399396
.build();
400397
return StsAssumeRoleCredentialsProvider.builder()
401398
.stsClient(getStsClientBuilder(Region.of(stsRegion)).build())
402-
.asyncCredentialUpdateEnabled(true)
403399
.refreshRequest(roleRequest)
404400
.asyncCredentialUpdateEnabled(true)
405401
.build();

0 commit comments

Comments
 (0)