From ef071a5cd0d06a2694ceaadd3f8f7546862a5639 Mon Sep 17 00:00:00 2001 From: Tiationg Kho Date: Tue, 25 Feb 2025 11:28:33 -0800 Subject: [PATCH 1/2] Fix helm default val for heartbeat flags --- config/helm/aws-node-termination-handler/values.yaml | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/config/helm/aws-node-termination-handler/values.yaml b/config/helm/aws-node-termination-handler/values.yaml index f6c7bf42..c1b93339 100644 --- a/config/helm/aws-node-termination-handler/values.yaml +++ b/config/helm/aws-node-termination-handler/values.yaml @@ -285,6 +285,12 @@ enableRebalanceDraining: false # deleteSqsMsgIfNodeNotFound If true, delete the SQS Message from the SQS Queue if the targeted node(s) are not found. Only used in Queue Processor mode. deleteSqsMsgIfNodeNotFound: false +# The time period in seconds between consecutive heartbeat signals. Valid range: 30-3600 seconds (30 seconds to 1 hour). +heartbeatInterval: -1 + +# The duration in seconds over which heartbeat signals are sent. Valid range: 60-172800 seconds (1 minute to 48 hours). +heartbeatUntil: -1 + # --------------------------------------------------------------------------------------------------------------------- # Testing # --------------------------------------------------------------------------------------------------------------------- From 1aa30513599e58c168c6b77866eccf3adbc887c1 Mon Sep 17 00:00:00 2001 From: Tiationg Kho Date: Tue, 25 Feb 2025 11:49:27 -0800 Subject: [PATCH 2/2] Fix helm readme --- config/helm/aws-node-termination-handler/README.md | 3 +++ 1 file changed, 3 insertions(+) diff --git a/config/helm/aws-node-termination-handler/README.md b/config/helm/aws-node-termination-handler/README.md index 06ceac1a..4c35a886 100644 --- a/config/helm/aws-node-termination-handler/README.md +++ b/config/helm/aws-node-termination-handler/README.md @@ -120,6 +120,9 @@ The configuration in this table applies to AWS Node Termination Handler in queue | `managedAsgTag` | [DEPRECATED](Use `managedTag` instead) The node tag to check if `checkASGTagBeforeDraining` is `true`. | `useProviderId` | If `true`, fetch node name through Kubernetes node spec ProviderID instead of AWS event PrivateDnsHostname. | `false` | | `topologySpreadConstraints` | [Topology Spread Constraints](https://kubernetes.io/docs/concepts/scheduling-eviction/topology-spread-constraints/) for pod scheduling. Useful with a highly available deployment to reduce the risk of running multiple replicas on the same Node | `[]` | +| `heartbeatInterval` | The time period in seconds between consecutive heartbeat signals. Valid range: 30-3600 seconds (30 seconds to 1 hour). | `-1` | +| `heartbeatUntil` | The duration in seconds over which heartbeat signals are sent. Valid range: 60-172800 seconds (1 minute to 48 hours). | `-1` | + ### IMDS Mode Configuration The configuration in this table applies to AWS Node Termination Handler in IMDS mode.