Skip to content

Commit 09e0d6b

Browse files
authored
Re-enable disabled S3 tests (#3876)
1 parent be52b8f commit 09e0d6b

File tree

1 file changed

+15
-17
lines changed

1 file changed

+15
-17
lines changed

services/s3/src/test/java/software/amazon/awssdk/services/s3/EndpointOverrideEndpointResolutionTest.java

+15-17
Original file line numberDiff line numberDiff line change
@@ -230,14 +230,13 @@ public static Collection<TestCase> testCases() {
230230
.setExpectedSigningServiceName("s3")
231231
.setExpectedSigningRegion(Region.US_WEST_2));
232232

233-
//FIXME: The ruleset is currently broken for this test case. The provider is not preserving the path part
234-
// cases.add(new TestCase().setCaseName("access point with http, path, query, and port")
235-
// .setGetObjectBucketName("arn:aws:s3:us-west-2:123456789012:accesspoint:myendpoint")
236-
// .setEndpointUrl("http://beta.example.com:1234/path?foo=bar")
237-
// .setClientRegion(Region.US_WEST_2)
238-
// .setExpectedEndpoint("http://myendpoint-123456789012.beta.example.com:1234/path/object?foo=bar")
239-
// .setExpectedSigningServiceName("s3")
240-
// .setExpectedSigningRegion(Region.US_WEST_2));
233+
cases.add(new TestCase().setCaseName("access point with http, path, query, and port")
234+
.setGetObjectBucketName("arn:aws:s3:us-west-2:123456789012:accesspoint:myendpoint")
235+
.setEndpointUrl("http://beta.example.com:1234/path?foo=bar")
236+
.setClientRegion(Region.US_WEST_2)
237+
.setExpectedEndpoint("http://myendpoint-123456789012.beta.example.com:1234/path/object?foo=bar")
238+
.setExpectedSigningServiceName("s3")
239+
.setExpectedSigningRegion(Region.US_WEST_2));
241240

242241
cases.add(new TestCase().setCaseName("outposts access point")
243242
.setGetObjectBucketName("arn:aws:s3-outposts:us-west-2:123456789012:outpost:op-01234567890123456:accesspoint:myaccesspoint")
@@ -313,15 +312,14 @@ public static Collection<TestCase> testCases() {
313312
.setExpectedSigningServiceName("s3")
314313
.setExpectedSigningRegion(Region.US_WEST_2));
315314

316-
//FIXME: The ruleset is currently broken for this test case. The provider is not preserving the path part
317-
// cases.add(new TestCase().setCaseName("access point with http, path, query, port, different arn region, and arn region enabled")
318-
// .setGetObjectBucketName("arn:aws:s3:us-west-2:123456789012:accesspoint:myendpoint")
319-
// .setEndpointUrl("http://accesspoint.vpce-123-abc.s3.us-west-2.vpce.amazonaws.com:1234/path?foo=bar")
320-
// .setS3Configuration(c -> c.useArnRegionEnabled(true))
321-
// .setClientRegion(Region.EU_WEST_1)
322-
// .setExpectedEndpoint("http://myendpoint-123456789012.accesspoint.vpce-123-abc.s3.us-west-2.vpce.amazonaws.com:1234/path/object?foo=bar")
323-
// .setExpectedSigningServiceName("s3")
324-
// .setExpectedSigningRegion(Region.US_WEST_2));
315+
cases.add(new TestCase().setCaseName("access point with http, path, query, port, different arn region, and arn region enabled")
316+
.setGetObjectBucketName("arn:aws:s3:us-west-2:123456789012:accesspoint:myendpoint")
317+
.setEndpointUrl("http://accesspoint.vpce-123-abc.s3.us-west-2.vpce.amazonaws.com:1234/path?foo=bar")
318+
.setS3Configuration(c -> c.useArnRegionEnabled(true))
319+
.setClientRegion(Region.EU_WEST_1)
320+
.setExpectedEndpoint("http://myendpoint-123456789012.accesspoint.vpce-123-abc.s3.us-west-2.vpce.amazonaws.com:1234/path/object?foo=bar")
321+
.setExpectedSigningServiceName("s3")
322+
.setExpectedSigningRegion(Region.US_WEST_2));
325323

326324
cases.add(new TestCase().setCaseName("outposts access point with dual stack enabled via s3 config")
327325
.setGetObjectBucketName("arn:aws:s3-outposts:us-west-2:123456789012:outpost:op-01234567890123456:accesspoint:myaccesspoint")

0 commit comments

Comments
 (0)