ProxyConfiguration.toBuilder throws NullPointerException

[mosche]

Describe the bug

ProxyConfiguration.toBuilder throws NullPointerException if nonProxyHosts is unset:

java.lang.NullPointerException
	at java.util.HashSet.<init>(HashSet.java:119)
	at software.amazon.awssdk.http.apache.ProxyConfiguration$DefaultClientProxyConfigurationBuilder.nonProxyHosts(ProxyConfiguration.java:368)
	at software.amazon.awssdk.http.apache.ProxyConfiguration.toBuilder(ProxyConfiguration.java:163)

The problematic code this:

        @Override
        public Builder nonProxyHosts(Set<String> nonProxyHosts) {
            this.nonProxyHosts = new HashSet<>(nonProxyHosts);
            return this;
        }

Expected behavior

ProxyConfiguration.toBuilder should work on any possible ProxyConfiguration.

Current behavior

Throws exception

Steps to Reproduce

    ProxyConfiguration proxyConfiguration =
        ProxyConfiguration.builder()
            .endpoint(URI.create("http://localhost:8080"))
            .username("username")
            .password("password")
            .build();
    proxyConfiguration.toBuilder();

Possible Solution

No response

Context

No response

AWS Java SDK version used

Latest

JDK version used

1.8

Operating System and version

[debora-ito]

Thank you for reporting this @mosche. We'll fix it.

[github-actions]

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.