Skip to content

Add support for fipsEnabled to S3CrtAsyncClientBuilder #3813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
2 tasks
tmccombs opened this issue Mar 6, 2023 · 5 comments
Open
2 tasks

Add support for fipsEnabled to S3CrtAsyncClientBuilder #3813

tmccombs opened this issue Mar 6, 2023 · 5 comments
Labels
crt-client feature-request A feature should be added or improved. p2 This is a standard priority issue

Comments

@tmccombs
Copy link

tmccombs commented Mar 6, 2023

Describe the feature

S3CrtAsyncClientBuilder is missing a lot of functions available for S3AsyncClientBuilder. In particular for my use case the fipsEnabled method.

I would like to be able to use fipsEnabled when using the CRT client.

Use Case

I would like to create a an S3CrtAsyncClient that use fips. But the builder doesn't have an API for that.

Proposed Solution

I think it would make sense for S3CrtAsyncClientBuilder to exted S3AsyncClientBuilder, or at least AwsClientBuilder.

if that isn't feasible for some reason add a fipsEnabled method similar to that on AwsClientBuilder.

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

AWS Java SDK version used

2.20.17

JDK version used

11.0.18

Operating System and version

Ubuntu 20.04

@tmccombs tmccombs added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Mar 6, 2023
@debora-ito
Copy link
Member

debora-ito commented Mar 7, 2023

@tmccombs noted, thank you for reaching out. The feature is in our backlog already.

@debora-ito debora-ito removed the needs-triage This issue or PR still needs to be triaged. label Mar 7, 2023
@debora-ito debora-ito changed the title Add support for fipsEnabeld to S3CrtAsyncClientBuilder Add support for fipsEnabled to S3CrtAsyncClientBuilder Mar 7, 2023
@akolacca
Copy link

akolacca commented Mar 8, 2023

@debora-ito when do you think this will get implemented approximately?

@akolacca
Copy link

@debora-ito any progress around this issue? This is very important to my company since we really need the crt capabilities, and it will be a horrible waste of time to implement the multipart and range download on our own

@akolacca
Copy link

Any progress here?

@debora-ito
Copy link
Member

@akolacca we usually don't comment on release timelines, but we understand that this is a blocker for people who want to migrate to v2 TransferManager and use the full capabilities of the S3CrtAsync client.

@debora-ito debora-ito added the p2 This is a standard priority issue label Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
crt-client feature-request A feature should be added or improved. p2 This is a standard priority issue
Projects
None yet
Development

No branches or pull requests

3 participants