Skip to content

Missing parameter in S3AsyncClient.crtBuilder() - serviceConfiguration #3821

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
akolacca opened this issue Mar 8, 2023 · 8 comments
Closed
Labels
feature-request A feature should be added or improved.

Comments

@akolacca
Copy link

akolacca commented Mar 8, 2023

Describe the feature

I need the serviceConfiguration parameter that exists in S3AsyncClient.builder() since this parameter enabled me to connect to S3, and without it I cannot configure many important S3 configurations. The parameters I needed were checksumValidationEnabled(false) and pathStyleAccessEnabled(true).

Use Case

I need to connect to S3 and I cannot use the CRT client for this. Because of this I need to implement S3 multi part uploading and routes splitting all by myself, which is pretty hard and redundant. I would really love to get the support for the serviceConfiguration. This is by far the most needed feature to me, since without it I cannot even connect.

Proposed Solution

Support serviceConfiguration from the S3AsyncClient.crtBuilder().

Other Information

No response

AWS Java SDK version used

2.20.16

JDK version used

17

Operating System and version

Linux

@akolacca akolacca added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Mar 8, 2023
@akolacca
Copy link
Author

akolacca commented Mar 8, 2023

Currently my S3AsyncClient gets stuck when I download large files from S3. I would like to use the CRT client because I think the byte-range fetches would solve this to me

@zoewangg zoewangg removed the needs-triage This issue or PR still needs to be triaged. label Mar 8, 2023
@zoewangg
Copy link
Contributor

zoewangg commented Mar 8, 2023

Hi @akolacca, forcePathStyle support is tracked in #3817. checksumValidationEnabled config is available in S3CrtAsyncClientBuilder https://github.com/aws/aws-sdk-java-v2/blob/master/services/s3/src/main/java/software/amazon/awssdk/services/s3/S3CrtAsyncClientBuilder.java#L139

@zoewangg zoewangg added the response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 10 days. label Mar 8, 2023
@akolacca
Copy link
Author

akolacca commented Mar 8, 2023

@zoewangg Regarding the checksum - thanks alot! Regarding the forcePathStyle - that's not what I meant. I meant:

S3Configuration serviceConfiguration = S3Configuration.builder()
    .pathStyleAccessEnabled(true)
    .build();

But I see it has similar effect (am I right?) so I'm good with forcePathStyle.
Any timeline estimates?

@github-actions github-actions bot removed the response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 10 days. label Mar 8, 2023
@zoewangg
Copy link
Contributor

zoewangg commented Mar 8, 2023

Yes, it has the same effect. We don't have a timeline for that at the moment. Feel free add 👍🏼 to #3817, which will help us prioritize. I'll go ahead and close this issue for now.

@zoewangg zoewangg closed this as completed Mar 8, 2023
@github-actions
Copy link

github-actions bot commented Mar 8, 2023

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

@akolacca
Copy link
Author

@zoewangg can you tell approximately when this will get implemented? The support for this is very crucial

@akolacca
Copy link
Author

@zoewangg @debora-ito Can you update us about the progress here?

@debora-ito
Copy link
Member

@akolacca please track the issue that is open #3817, we'll post any updates over there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request A feature should be added or improved.
Projects
None yet
Development

No branches or pull requests

3 participants