Skip to content

The URL for homepage should link to package inside monorepo #379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
trivikr opened this issue Jul 6, 2022 · 1 comment · Fixed by #380
Closed

The URL for homepage should link to package inside monorepo #379

trivikr opened this issue Jul 6, 2022 · 1 comment · Fixed by #380

Comments

@trivikr
Copy link
Member

trivikr commented Jul 6, 2022

Is your feature request related to a problem? Please describe

The homepage field for the individual packages (if present) links to root of the monorepo.
The folks using the link and landing on GitHub have to go through monorepo structure, and find out the correct package.

For example, open @aws-crypto/crc32c on npm, and click on Homepage in the right sidebar.

Screenshot

aws-crypto-crc32c

The page opened will be https://github.com/aws/aws-sdk-js-crypto-helpers#readme

Describe the solution you'd like to see

The homepage config should link to folder where source code for the package is present.

For @aws-crypto/crc32c package, the URL stored in homepage should be https://github.com/aws/aws-sdk-js-crypto-helpers/tree/master/packages/crc32c

Describe alternatives you've considered

N/A

@josecorella
Copy link
Contributor

Hi @trivikr!
Thank you for bringing this to our attention and cutting the PR with the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants