Skip to content

Commit 54ff141

Browse files
authored
chore(scripts): use asterisk for internal deps when generating clients (#3224)
1 parent c237972 commit 54ff141

File tree

1 file changed

+1
-22
lines changed

1 file changed

+1
-22
lines changed

Diff for: scripts/generate-clients/copy-to-clients.js

+1-22
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ const mergeManifest = (fromContent = {}, toContent = {}) => {
6060
} else if (name.indexOf("@aws-sdk/") === 0) {
6161
// If it's internal dependency, use current version in the repo if not
6262
// present in package.json
63-
merged[name] = toContent[name] || getInternalDepVersion(name);
63+
merged[name] = toContent[name] || "*";
6464
} else {
6565
// If key (say dependency) is present in both codegen and
6666
// package.json, we prefer latter
@@ -70,27 +70,6 @@ const mergeManifest = (fromContent = {}, toContent = {}) => {
7070
return merged;
7171
};
7272

73-
/**
74-
* Returns current version number of the internal dependency version passed.
75-
*/
76-
const getInternalDepVersion = (depName) => {
77-
if (depName.indexOf("@aws-sdk/") !== 0) {
78-
throw new Error(`getInternalDepVersion called for external dep: "${depName}"`);
79-
}
80-
81-
const packageName = depName.substr(9);
82-
const packagesDir = normalize(join(__dirname, "..", "..", "packages"));
83-
const clientsDir = normalize(join(__dirname, "..", "..", "clients"));
84-
85-
if (existsSync(`${packagesDir}/${packageName}`)) {
86-
return require(`${packagesDir}/${packageName}/package.json`).version;
87-
} else if (existsSync(`${clientsDir}/${packageName}`)) {
88-
return require(`${clientsDir}/${packageName}/package.json`).version;
89-
}
90-
91-
throw new Error(`Internal dependency "${packageName}" not found`);
92-
};
93-
9473
const copyToClients = async (sourceDir, destinationDir) => {
9574
for (const modelName of readdirSync(sourceDir)) {
9675
if (modelName === "source") continue;

0 commit comments

Comments
 (0)