Skip to content

Commit 7480f74

Browse files
author
Chase Coalwell
authored
feat: migrate bucketEndpointMiddleware (#552)
feat: name package feat: migrate and apply middleware feat: remove $ input options feat: remove preformedBucket option
1 parent a77cce3 commit 7480f74

20 files changed

+266
-304
lines changed

codegen/smithy-aws-typescript-codegen/src/main/java/software/amazon/smithy/aws/typescript/codegen/AddBuiltinPlugins.java

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -51,6 +51,12 @@ public class AddBuiltinPlugins implements TypeScriptIntegration {
5151
"PutBucketReplication"
5252
);
5353

54+
private static final Set<String> NON_BUCKET_ENDPOINT_OPERATIONS = SetUtils.of(
55+
"CreateBucket",
56+
"DeleteBucket",
57+
"ListBuckets"
58+
);
59+
5460
@Override
5561
public List<RuntimeClientPlugin> getClientPlugins() {
5662
// Note that order is significant because configurations might
@@ -112,6 +118,12 @@ public List<RuntimeClientPlugin> getClientPlugins() {
112118
.servicePredicate((m, s) -> testServiceId(s, "Machine Learning"))
113119
.operationPredicate((m, s, o) -> o.getId().getName().equals("Predict"))
114120
.build(),
121+
RuntimeClientPlugin.builder()
122+
.withConventions(AwsDependency.BUCKET_ENDPOINT_MIDDLEWARE.dependency, "BucketEndpoint",
123+
HAS_MIDDLEWARE)
124+
.servicePredicate((m, s) -> testServiceId(s, "S3"))
125+
.operationPredicate((m, s, o) -> !NON_BUCKET_ENDPOINT_OPERATIONS.contains(o.getId().getName()))
126+
.build(),
115127
RuntimeClientPlugin.builder()
116128
.withConventions(AwsDependency.BODY_CHECKSUM.dependency, "ApplyMd5BodyChecksum",
117129
HAS_MIDDLEWARE)

codegen/smithy-aws-typescript-codegen/src/main/java/software/amazon/smithy/aws/typescript/codegen/AwsDependency.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -42,6 +42,7 @@ public enum AwsDependency implements SymbolDependencyContainer {
4242
STREAM_HASHER_NODE(NORMAL_DEPENDENCY, "@aws-sdk/hash-stream-node", "^0.1.0-preview.4"),
4343
STREAM_HASHER_BROWSER(NORMAL_DEPENDENCY, "@aws-sdk/hash-blob-browser", "^0.1.0-preview.4"),
4444
ROUTE53_MIDDLEWARE(NORMAL_DEPENDENCY, "@aws-sdk/middleware-sdk-route53", "^0.1.0-preview.1"),
45+
BUCKET_ENDPOINT_MIDDLEWARE(NORMAL_DEPENDENCY, "@aws-sdk/middleware-bucket-endpoint", "^0.1.0-preview.5"),
4546
BODY_CHECKSUM(NORMAL_DEPENDENCY, "@aws-sdk/middleware-apply-body-checksum", "^0.1.0-preview.5");
4647

4748
public final String packageName;

packages/bucket-endpoint-middleware/README.md

Lines changed: 0 additions & 4 deletions
This file was deleted.

packages/bucket-endpoint-middleware/src/bucketEndpointMiddleware.spec.ts

Lines changed: 0 additions & 222 deletions
This file was deleted.

packages/bucket-endpoint-middleware/src/bucketEndpointMiddleware.ts

Lines changed: 0 additions & 73 deletions
This file was deleted.
Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
1+
# @aws-sdk/middleware-bucket-endpoint
2+
3+
[![NPM version](https://img.shields.io/npm/v/@aws-sdk/middleware-bucket-endpoint/preview.svg)](https://www.npmjs.com/package/@aws-sdk/middleware-bucket-endpoint)
4+
[![NPM downloads](https://img.shields.io/npm/dm/@aws-sdk/middleware-bucket-endpoint.svg)](https://www.npmjs.com/package/@aws-sdk/middleware-bucket-endpoint)

packages/bucket-endpoint-middleware/package.json renamed to packages/middleware-bucket-endpoint/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
{
2-
"name": "@aws-sdk/bucket-endpoint-middleware",
2+
"name": "@aws-sdk/middleware-bucket-endpoint",
33
"version": "0.1.0-preview.5",
44
"scripts": {
55
"prepublishOnly": "tsc",

0 commit comments

Comments
 (0)