Skip to content

Commit ad25cec

Browse files
committed
test: accesspoint ARN with dualstack enabled
1 parent ce4db0d commit ad25cec

File tree

1 file changed

+12
-5
lines changed

1 file changed

+12
-5
lines changed

packages/middleware-bucket-endpoint/src/bucketHostname.spec.ts

Lines changed: 12 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -188,20 +188,24 @@ describe("bucketHostname", () => {
188188

189189
describe("from Access Point ARN", () => {
190190
describe("populates access point endpoint from ARN", () => {
191-
const s3Hostname = "s3.us-west-2.amazonaws.com";
192191
const customHostname = "example.com";
193192

194-
describe(`baseHostname: ${s3Hostname}`, () => {
195-
const baseHostname = s3Hostname;
193+
describe.each([
194+
["s3.us-west-2.amazonaws.com", false],
195+
["s3.dualstack.us-west-2.amazonaws.com", true],
196+
])(`baseHostname: %s, dualstackEndpoint: %s`, (baseHostname, dualstackEndpoint) => {
196197
it("should use client region", () => {
197198
const { bucketEndpoint, hostname } = bucketHostname({
198199
bucketName: parseArn("arn:aws:s3:us-west-2:123456789012:accesspoint:myendpoint"),
199200
baseHostname,
200201
isCustomEndpoint: false,
201202
clientRegion: region,
203+
dualstackEndpoint,
202204
});
203205
expect(bucketEndpoint).toBe(true);
204-
expect(hostname).toBe("myendpoint-123456789012.s3-accesspoint.us-west-2.amazonaws.com");
206+
expect(hostname).toBe(
207+
`myendpoint-123456789012.s3-accesspoint${dualstackEndpoint ? ".dualstack" : ""}.us-west-2.amazonaws.com`
208+
);
205209
});
206210

207211
it("should use ARN region", () => {
@@ -211,9 +215,12 @@ describe("bucketHostname", () => {
211215
isCustomEndpoint: false,
212216
clientRegion: region,
213217
useArnRegion: true,
218+
dualstackEndpoint,
214219
});
215220
expect(bucketEndpoint).toBe(true);
216-
expect(hostname).toBe("myendpoint-123456789012.s3-accesspoint.us-east-1.amazonaws.com");
221+
expect(hostname).toBe(
222+
`myendpoint-123456789012.s3-accesspoint${dualstackEndpoint ? ".dualstack" : ""}.us-east-1.amazonaws.com`
223+
);
217224
});
218225
});
219226

0 commit comments

Comments
 (0)