Skip to content

Commit b404c8b

Browse files
committed
fix(middleware-bucket-endpoint): remove dualstack from hostname before processing
1 parent f2fb280 commit b404c8b

File tree

2 files changed

+3
-1
lines changed

2 files changed

+3
-1
lines changed

packages/middleware-bucket-endpoint/src/bucketHostname.spec.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@ describe("bucketHostname", () => {
66
const region = "us-west-2";
77
describe("from bucket name", () => {
88
[
9+
{ baseHostname: "s3.dualstack.us-west-2.amazonaws.com", isCustomEndpoint: false, dualstackEndpoint: true },
910
{ baseHostname: "s3.us-west-2.amazonaws.com", isCustomEndpoint: false },
1011
{ baseHostname: "beta.example.com", isCustomEndpoint: true },
1112
].forEach(({ baseHostname, isCustomEndpoint }) => {

packages/middleware-bucket-endpoint/src/bucketHostname.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,8 @@ const getEndpointFromBucketName = ({
5151
tlsCompatible = true,
5252
isCustomEndpoint = false,
5353
}: BucketHostnameParams): BucketHostname => {
54-
const [clientRegion, hostnameSuffix] = isCustomEndpoint ? [region, baseHostname] : getSuffix(baseHostname);
54+
const suffixHostname = dualstackEndpoint ? baseHostname.replace(".dualstack", "") : baseHostname;
55+
const [clientRegion, hostnameSuffix] = isCustomEndpoint ? [region, baseHostname] : getSuffix(suffixHostname);
5556
if (pathStyleEndpoint || !isDnsCompatibleBucketName(bucketName) || (tlsCompatible && DOT_PATTERN.test(bucketName))) {
5657
return {
5758
bucketEndpoint: false,

0 commit comments

Comments
 (0)