Merge pull request #449 from aws/fix-cloudsearchdomain-signing

Fix CloudSearchDomain signing on EC2 instance

Author: lsegal

lib/services/cloudsearchdomain.js

@@ -71,14 +71,21 @@ AWS.util.update(AWS.CloudSearchDomain.prototype, {
    * @api private
    */
   setupRequestListeners: function setupRequestListeners(request) {
-    if (!request.service.config.credentials) {
-      request.removeListener('validate',
-                             AWS.EventListeners.Core.VALIDATE_CREDENTIALS
-                            );
-      request.removeListener('sign', AWS.EventListeners.Core.SIGN);
-    } else {
-      request.addListener('validate', this.updateRegion);
-    }
+    request.removeListener('validate',
+      AWS.EventListeners.Core.VALIDATE_CREDENTIALS
+    );
+    request.onAsync('validate', this.validateCredentials);
+    request.addListener('validate', this.updateRegion);
+  },
+
+  validateCredentials: function(req, done) {
+    if (!req.service.api.signatureVersion) return done(); // none
+    req.service.config.getCredentials(function(err) {
+      if (err) {
+        req.removeListener('sign', AWS.EventListeners.Core.SIGN);
+      }
+      done();
+    });
   },
 
   /**

test/credential_provider_chain.spec.coffee

@@ -16,6 +16,7 @@ if AWS.util.isNode()
 
       afterEach ->
         AWS.CredentialProviderChain.defaultProviders = defaultProviders
+        process.env = {}
 
       it 'returns an error by default', ->
         chain.resolve (err) ->

test/credentials.spec.coffee

@@ -91,6 +91,9 @@ if AWS.util.isNode()
     beforeEach ->
       process.env = {}
 
+    afterEach ->
+      process.env = {}
+
     describe 'constructor', ->
       it 'should be able to read credentials from env with a prefix', ->
         process.env.AWS_ACCESS_KEY_ID = 'akid'