Skip to content

AWS_PROFILE to respect config role_arn #1296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mattbailey opened this issue Jan 11, 2017 · 2 comments · Fixed by #1391
Closed

AWS_PROFILE to respect config role_arn #1296

mattbailey opened this issue Jan 11, 2017 · 2 comments · Fixed by #1391
Labels
feature-request A feature should be added or improved.

Comments

@mattbailey
Copy link

Support for AWS_PROFILE is great, but without automatically assuming the role_arn in ~/.aws/config for that profile makes it useless for the most common use case for even having profiles (master account delegating access to other accounts). The node.js SDK appears to just ignore this role_arn and try to perform actions on the "master" account.

This could be potentially dangerous, since it behaves differently from the CLI, one might issue commands on an unintended account.

@jeskew
Copy link
Contributor

jeskew commented Jan 19, 2017

Hi @mattbailey,

I understand your concern, but the SDK does not currently read any values from the ~/.aws/config file. It will, however, assume roles specified using a role_arn provided in the ~/.aws/credentials file. It would arguably be dangerous to start reading from the config file now, as customers might now be relying on that file only being used by the AWS CLI. If we do add support for autoloading profile data from ~/.aws/config, it would need to be opt in.

@lock
Copy link

lock bot commented Sep 29, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@lock lock bot locked as resolved and limited conversation to collaborators Sep 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request A feature should be added or improved.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants