Add Buffer and Stream support for S3

[tracker1]

Would be nice to be able to pass a buffer, or stream in addition to a base-64 encoded string. Since these are the typical interfaces for dealing with binary data in Node.js

[reconbot]

+1

[Rob-ot]

+1

[trevorrowe]

This is a known omission at this point. We will definitely be adding proper support for working with binary data.

[tracker1]

Absolutely appreciated... I know supporting a Buffer should be simple enough, and wrapping a stream interface could be a bit more of a pain.

[dominicbarnes]

+1

[deanmao]

Ok cool. so it has nothing to do with my code then... I naively assumed I could download files with their s3 library. But there's some weird utf-conversion issue.

[vanb]

+1

[deanmao]

I hacked in buffer support in my fork, only because I really needed it, but the code may not be very DRY:

deanmao@994aaec

However, it works... at least I can now download files from S3 and write to disk without having a weird utf-8 conversion screwing up all the bytes.

I could do a pull request, but maybe the library authors prefer the body-as-buffer to be set via a method parameter option instead?

Actually, shouldn't the body always be a buffer until we know we need to convert it to a string? I feel like that whole method could just be done a lot better...

[BharatMeda]

@trevorrowe Thank you. Looking forward for this feature.

[BharatMeda]

Would you be updating the package manager with the latest changes? Thanks in advance.

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.