Redundant check in hasRequiredEndpointDiscovery in endpoint discovery code

[trivikr]

Is your request related to a problem? Please describe.
Not a problem, but there's a check for hasRequiredEndpointDiscovery in endpoint discovery code under switch statement which is always expected to be false.

aws-sdk-js/lib/discover_endpoint.js

Lines 338 to 347 in d3ce713

	switch (isEndpointDiscoveryRequired) {
	case 'OPTIONAL':
	if (isEnabled || hasRequiredEndpointDiscovery) {
	// For a given service; if at least one operation requires endpoint discovery then the SDK must enable endpoint discovery
	// by default for all operations of that service, including operations where endpoint discovery is optional.
	optionalDiscoverEndpoint(request);
	request.addNamedListener('INVALIDATE_CACHED_ENDPOINTS', 'extractError', invalidateCachedEndpoints);
	}
	done();
	break;

• The switch case is when isEndpointDiscoveryRequired="OPTIONAL"
• This happens when operationModel is defined and it's endpointDiscoveryRequired is set to "OPTIONAL"

  aws-sdk-js/lib/discover_endpoint.js

  Line 330 in d3ce713

  var isEndpointDiscoveryRequired = operationModel ? operationModel.endpointDiscoveryRequired : 'NULL';

• This happens when operation.endpointdiscovery.required value is false or undefined.

  aws-sdk-js/lib/model/operation.js

  Lines 19 to 25 in d3ce713

  	property(
  	this,
  	'endpointDiscoveryRequired',
  	operation.endpointdiscovery ?
  	(operation.endpointdiscovery.required ? 'REQUIRED' : 'OPTIONAL') :
  	'NULL'
  	);

• The property hasRequiredEndpointDiscovery is not set when operation.endpointdiscovery.required is false or undefined

  aws-sdk-js/lib/model/api.js

  Lines 54 to 60 in d3ce713

  	if (operation.endpointdiscovery && !self.hasRequiredEndpointDiscovery) {
  	property(
  	self,
  	'hasRequiredEndpointDiscovery',
  	operation.endpointdiscovery.required === true
  	);
  	}

Describe the solution you'd like
Remove redundant hasRequiredEndpointDiscovery check from OPTIONAL switch case for isEndpointDiscoveryRequired.

Additional context
This was noticed while implementing endpoint discovery for AWS SDK for JavaScript (v3) in aws/aws-sdk-js-v3#2211

[github-actions]

Greetings! We’re closing this issue because it has been open a long time and hasn’t been updated in a while and may not be getting the attention it deserves. We encourage you to check if this is still an issue in the latest release and if you find that this is still a problem, please feel free to comment or open a new issue.