Skip to content

Commit 260b78d

Browse files
committed
Renamed unit test and removed unnecessary comments
1 parent 8dd38ec commit 260b78d

File tree

2 files changed

+3
-9
lines changed

2 files changed

+3
-9
lines changed

tests/integ/test_sagemaker_steps.py

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -104,7 +104,6 @@ def test_training_step(pca_estimator_fixture, record_set_fixture, sfn_client, sf
104104

105105
# Cleanup
106106
state_machine_delete_wait(sfn_client, workflow.state_machine_arn)
107-
# End of Cleanup
108107

109108

110109
def test_training_step_with_placeholders(pca_estimator_fixture, record_set_fixture, sfn_client, sfn_role_arn):
@@ -193,7 +192,7 @@ def test_model_step(trained_estimator, sfn_client, sagemaker_session, sfn_role_a
193192
state_machine_delete_wait(sfn_client, workflow.state_machine_arn)
194193
model_name = get_resource_name_from_arn(execution_output.get("ModelArn")).split("/")[1]
195194
delete_sagemaker_model(model_name, sagemaker_session)
196-
# End of Cleanup
195+
197196

198197
def test_transform_step(trained_estimator, sfn_client, sfn_role_arn):
199198
# Create transformer from previously created estimator
@@ -235,7 +234,6 @@ def test_transform_step(trained_estimator, sfn_client, sfn_role_arn):
235234

236235
# Cleanup
237236
state_machine_delete_wait(sfn_client, workflow.state_machine_arn)
238-
# End of Cleanup
239237

240238

241239
def test_transform_step_with_placeholder(trained_estimator, sfn_client, sfn_role_arn):
@@ -360,7 +358,7 @@ def test_endpoint_config_step(trained_estimator, sfn_client, sagemaker_session,
360358
state_machine_delete_wait(sfn_client, workflow.state_machine_arn)
361359
delete_sagemaker_endpoint_config(endpoint_config_name, sagemaker_session)
362360
delete_sagemaker_model(model.name, sagemaker_session)
363-
# End of Cleanup
361+
364362

365363
def test_create_endpoint_step(trained_estimator, record_set_fixture, sfn_client, sagemaker_session, sfn_role_arn):
366364
# Setup: Create model and endpoint config for trained estimator in SageMaker
@@ -403,7 +401,6 @@ def test_create_endpoint_step(trained_estimator, record_set_fixture, sfn_client,
403401
delete_sagemaker_endpoint(endpoint_name, sagemaker_session)
404402
delete_sagemaker_endpoint_config(model.name, sagemaker_session)
405403
delete_sagemaker_model(model.name, sagemaker_session)
406-
# End of Cleanup
407404

408405

409406
def test_tuning_step(sfn_client, record_set_for_hyperparameter_tuning, sagemaker_role_arn, sfn_role_arn):
@@ -455,7 +452,6 @@ def test_tuning_step(sfn_client, record_set_for_hyperparameter_tuning, sagemaker
455452

456453
# Cleanup
457454
state_machine_delete_wait(sfn_client, workflow.state_machine_arn)
458-
# End of Cleanup
459455

460456

461457
def test_tuning_step_with_placeholders(sfn_client, record_set_for_hyperparameter_tuning, sagemaker_role_arn, sfn_role_arn):
@@ -546,7 +542,6 @@ def test_tuning_step_with_placeholders(sfn_client, record_set_for_hyperparameter
546542

547543
# Cleanup
548544
state_machine_delete_wait(sfn_client, workflow.state_machine_arn)
549-
# End of Cleanup
550545

551546

552547
def test_processing_step(sklearn_processor_fixture, sagemaker_session, sfn_client, sfn_role_arn):
@@ -601,7 +596,6 @@ def test_processing_step(sklearn_processor_fixture, sagemaker_session, sfn_clien
601596

602597
# Cleanup
603598
state_machine_delete_wait(sfn_client, workflow.state_machine_arn)
604-
# End of Cleanup
605599

606600

607601
def test_processing_step_with_placeholders(sklearn_processor_fixture, sagemaker_session, sfn_client, sfn_role_arn,

tests/unit/test_sagemaker_steps.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1449,7 +1449,7 @@ def test_processing_step_creation_with_placeholders(sklearn_processor):
14491449

14501450
@patch('botocore.client.BaseClient._make_api_call', new=mock_boto_api_call)
14511451
@patch.object(boto3.session.Session, 'region_name', 'us-east-1')
1452-
def test_tuning_step_creation_with_framework(tensorflow_estimator):
1452+
def test_tuning_step_creation_with_framework_estimator(tensorflow_estimator):
14531453
hyperparameter_ranges = {
14541454
"extra_center_factor": IntegerParameter(4, 10),
14551455
"epochs": IntegerParameter(1, 2),

0 commit comments

Comments
 (0)