Removed eks:call.sync as it is not supported and removed logoptions parasms for eks:runJob

Author: ca-nguyen

src/stepfunctions/steps/service.py

@@ -507,7 +507,7 @@ class EksCallStep(Task):
     Creates a Task state that allows you to use the Kubernetes API to read and write Kubernetes resource objects via a Kubernetes API endpoint. See `Call Amazon EKS with Step Functions <https://docs.aws.amazon.com/step-functions/latest/dg/connect-eks.html>`_ for more details.
     """
 
-    def __init__(self, state_id, wait_for_completion=True, **kwargs):
+    def __init__(self, state_id, **kwargs):
         """
         Args:
             state_id (str): State name whose length **must be** less than or equal to 128 unicode characters. State names **must be** unique within the scope of the whole state machine.
@@ -520,23 +520,14 @@ def __init__(self, state_id, wait_for_completion=True, **kwargs):
             parameters (dict, optional): The value of this field becomes the effective input for the state.
             result_path (str, optional): Path specifying the raw input’s combination with or replacement by the state’s result. (default: '$')
             output_path (str, optional): Path applied to the state’s output after the application of `result_path`, producing the effective output which serves as the raw input for the next state. (default: '$')
-            wait_for_completion (bool, optional): Boolean value set to `True` if the Task state should wait to complete before proceeding to the next step in the workflow. (default: True)
         """
-        if wait_for_completion:
-            """
-            Example resource arn: arn:aws:states:::eks:createCluster.sync
-            """
 
-            kwargs[Field.Resource.value] = get_service_integration_arn(EKS_SERVICES_NAME,
-                                                                       EksApi.Call,
-                                                                       IntegrationPattern.WaitForCompletion)
-        else:
-            """
-            Example resource arn: arn:aws:states:::eks:createCluster
-            """
+        """
+        Example resource arn: arn:aws:states:::eks:createCluster
+        """
 
-            kwargs[Field.Resource.value] = get_service_integration_arn(EKS_SERVICES_NAME,
-                                                                       EksApi.Call)
+        kwargs[Field.Resource.value] = get_service_integration_arn(EKS_SERVICES_NAME,
+                                                                   EksApi.Call)
 
         super(EksCallStep, self).__init__(state_id, **kwargs)
 

tests/unit/test_service_steps.py

@@ -984,9 +984,6 @@ def test_eks_run_job_step_creation():
         'ClusterName': 'MyCluster',
         'CertificateAuthority': 'ANPAJ2UCCR6DPCEXAMPLE',
         'Endpoint': 'https://AKIAIOSFODNN7EXAMPLE.yl4.us-east-1.eks.amazonaws.com',
-        'LogOptions': {
-            'RetrieveLogs': True
-        },
         'Job': {
             'apiVersion': 'batch/v1',
             'kind': 'Job',
@@ -1046,8 +1043,7 @@ def test_eks_run_job_step_creation():
                             'restartPolicy': 'Never'}
                     }
                 }
-            },
-            'LogOptions': {'RetrieveLogs': True}
+            }
         },
         'End': True
     }
@@ -1101,6 +1097,9 @@ def test_eks_run_job_step_creation_sync():
             'CertificateAuthority': 'ANPAJ2UCCR6DPCEXAMPLE',
             'ClusterName': 'MyCluster',
             'Endpoint': 'https://AKIAIOSFODNN7EXAMPLE.yl4.us-east-1.eks.amazonaws.com',
+            'LogOptions': {
+                'RetrieveLogs': True
+            },
             'Job': {
                 'apiVersion': 'batch/v1',
                 'kind': 'Job',
@@ -1121,16 +1120,15 @@ def test_eks_run_job_step_creation_sync():
                             'restartPolicy': 'Never'}
                     }
                 }
-            },
-            'LogOptions': {'RetrieveLogs': True}
+            }
         },
         'End': True
     }
 
 
 @patch.object(boto3.session.Session, 'region_name', 'us-east-1')
 def test_eks_call_step_creation():
-    step = EksCallStep("Call", wait_for_completion=False, parameters={
+    step = EksCallStep("Call", parameters={
         'ClusterName': 'MyCluster',
         'CertificateAuthority': 'ANPAJ2UCCR6DPCEXAMPLE',
         'Endpoint': 'https://444455556666.yl4.us-east-1.eks.amazonaws.com',
@@ -1160,38 +1158,3 @@ def test_eks_call_step_creation():
         },
         'End': True
     }
-
-
-@patch.object(boto3.session.Session, 'region_name', 'us-east-1')
-def test_eks_call_step_creation_sync():
-    step = EksCallStep("Call sync", parameters={
-        'ClusterName': 'MyCluster',
-        'CertificateAuthority': 'ANPAJ2UCCR6DPCEXAMPLE',
-        'Endpoint': 'https://444455556666.yl4.us-east-1.eks.amazonaws.com',
-        'Method': 'GET',
-        'Path': '/api/v1/namespaces/default/pods',
-        'QueryParameters': {
-            'labelSelector': [
-                'job-name=example-job'
-            ]
-        }
-    })
-
-    assert step.to_dict() == {
-        'Type': 'Task',
-        'Resource': 'arn:aws:states:::eks:call.sync',
-        'Parameters': {
-            'ClusterName': 'MyCluster',
-            'CertificateAuthority': 'ANPAJ2UCCR6DPCEXAMPLE',
-            'Endpoint': 'https://444455556666.yl4.us-east-1.eks.amazonaws.com',
-            'Method': 'GET',
-            'Path': '/api/v1/namespaces/default/pods',
-            'QueryParameters': {
-                'labelSelector': [
-                    'job-name=example-job'
-                ]
-            }
-        },
-        'End': True
-    }
-