Skip to content

Customise Logging configuration #126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
DyfanJones opened this issue Mar 29, 2021 · 1 comment
Open

Customise Logging configuration #126

DyfanJones opened this issue Mar 29, 2021 · 1 comment
Labels
enhancement New feature or request

Comments

@DyfanJones
Copy link

Hi all,

I was wondering whether it is possible to change the logging configuration when creating/updating a state machine. From my current understanding the loggging configuration is set to default:

def _create(self):
response = self.client.create_state_machine(
name=self.name,
definition=self.definition.to_json(pretty=self.format_json),
roleArn=self.role,
tags=self.tags
)
logger.info("Workflow created successfully on AWS Step Functions.")
return response['stateMachineArn']

response = self.client.update_state_machine(
stateMachineArn=self.state_machine_arn,
definition=self.definition.to_json(pretty=self.format_json),
roleArn=self.role
)

@wong-a wong-a added the enhancement New feature or request label Mar 29, 2021
@wong-a
Copy link
Contributor

wong-a commented Mar 29, 2021

Hi @DyfanJones,

You're right. Workflow class doesn't expose a logging configuration parameter but there's no reason it shouldn't be in there as an optional parameter. By default, logging is off.

The API parameter is a dictionary (see boto3 docs) but there might be some abstraction we can do to help make it easier to set up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants