Using psycopg2 connection_factory throws exceptions

[mjgp2]

If using a connection factory, the connections are double wrapped and exceptions are thrown from psycopg2 type checking, e.g. TypeError: argument 2 must be a connection, cursor or None

e.g.

ThreadedConnectionPool(
    min_connections,
    max_connections,
    connection_string,
    connection_factory=iam_connection_factory(connection_string) if use_iam else None,
)

The workaround in the connection factory is to use connect.__wrapped__ instead of connect - then the connections are single wrapped.

[wangzlei]

Thanks for reporting the issue. Could you provide

1. the full source code of reproducing and the workaround by using connect.__wrapped__,
2. the exception stack logs

These can be great helpful to us in fixing the issue faster.

[mjgp2]

I can't get you stack logs, but here's a more complete example which basically does nothing, but if you try calling connect directly in the connection factory, you will see the error:

from psycopg2 import connect
def connection_factory(uri: str) -> Callable[[], connection]:
    do_connect = getattr(connect, "__wrapped__", connect)
    def connection_factory() -> connection:
        return do_connect(uri)
    return connection_factory

[jj22ee]

Hi @mjgp2, I am not able to reproduce locally. Could you help provide full code example of how you setup psycopg2 along with the aws-xray-sdk-python instrumentation for psycopg2? Is it still not possible to provide additional error logs?

[mjgp2]

I think perhaps it's similar to this issue: #350

I really should have given better steps to reproduce at the time, apologies.

I'm going to close this for now.