-
Notifications
You must be signed in to change notification settings - Fork 145
patch_all should take a flag for an alternative patching strategy #63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Hi, I answered this question in a stack overflow post here. But I copy/paste my answer here regardless: The node you see comes from this PR #19 for adding support to httplib. If you use The service graph however will render a "remote" subsegment as a node which is what you see. The recommended way is to explicit patch the library you want to capture to avoid unexpected behavior. |
Ok I understand what happens. However, I do not think it is a good design to leave Maybe we can do something to avoid this. For example, whenever a
|
Actually IMHO the SDK should ignore any new subsegment in a |
Thank you for the suggestions. These are very good points. There are use cases where user want to trace both But yes to your point the redundant nodes are confusing. I propose to have Please let me know your thoughts on this. |
Extra argument on |
This is added in release 2.0.0 with default to not do double patching. |
I created a lambda calling itself recursively for 3 times.
The lambda is set to“Enable active tracing”, and called
patch_all()
It uses
boto3
to send request.Code:
Expected graph
Real graph
Thinkings
In my understanding, a "remote" service means X-Ray does not recognize what endpoint it is, e.g. a non-AWS service. A call to AWS Lambda, shall have no "remote" services, with only one clean edge from the caller AWS service to the callee AWS service.
This redundant edge occurs more than here: When I call from lambda to Elastic Beanstalk endpoint, it still has "remote" services.
How do I get rid of them?
The text was updated successfully, but these errors were encountered: