Skip to content

Commit 3ef08e7

Browse files
authored
Merge branch 'main' into cdk-v2-build-scripts
2 parents db56b02 + 30737ae commit 3ef08e7

File tree

59 files changed

+1703
-1653
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

59 files changed

+1703
-1653
lines changed

source/patterns/@aws-solutions-constructs/aws-dynamodb-stream-lambda-elasticsearch-kibana/lib/index.ts

+6-1
Original file line numberDiff line numberDiff line change
@@ -117,8 +117,13 @@ export class DynamoDBStreamToLambdaToElasticSearchAndKibana extends Construct {
117117
constructor(scope: Construct, id: string, props: DynamoDBStreamToLambdaToElasticSearchAndKibanaProps) {
118118
super(scope, id);
119119
const convertedProps: DynamoDBStreamToLambdaToElasticSearchAndKibanaProps = { ...props };
120+
121+
// W (for 'wrapped') is added to the id so that the id's of the constructs with the old and new names don't collide
122+
// If this character pushes you beyond the 64 character limit, just import the new named construct and instantiate
123+
// it in place of the older named version. They are functionally identical, aside from the types no other changes
124+
// will be required. (eg - new DynamoDBStreamsToLambdaToElasticSearchAndKibana instead of DynamoDBStreamToLambdaToElasticSearchAndKibana)
120125
const wrappedConstruct: DynamoDBStreamToLambdaToElasticSearchAndKibana = new DynamoDBStreamsToLambdaToElasticSearchAndKibana(
121-
this, `${id}-wrapped`, convertedProps);
126+
this, `${id}W`, convertedProps);
122127

123128
this.lambdaFunction = wrappedConstruct.lambdaFunction;
124129
this.dynamoTable = wrappedConstruct.dynamoTable;

source/patterns/@aws-solutions-constructs/aws-dynamodb-stream-lambda-elasticsearch-kibana/test/__snapshots__/dynamodb-stream-lambda-elasticsearch-kibana.test.js.snap

+57-57
Large diffs are not rendered by default.

source/patterns/@aws-solutions-constructs/aws-dynamodb-stream-lambda-elasticsearch-kibana/test/dynamodb-stream-lambda-elasticsearch-kibana.test.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ test('check domain names', () => {
4545
expect(stack).toHaveResource('AWS::Cognito::UserPoolDomain', {
4646
Domain: "test-domain",
4747
UserPoolId: {
48-
Ref: "teststackteststackwrappedLambdaToElasticSearchCognitoUserPoolBA16EA97"
48+
Ref: "teststackteststackWLambdaToElasticSearchCognitoUserPool788087A8"
4949
}
5050
});
5151

0 commit comments

Comments
 (0)