Skip to content

Commit 47221d9

Browse files
authored
feat(aws-eventbridge-sns , aws-events-rule-sns, aws-events-rule-lambda): custom event bus support (#362)
* enhanced construct to support custom EventBus * fix linting issues * fix PR review comments * refactoring and use IEventBus instead of EventBus * added support for custom event bus * update the props naming convention to align with existing constructs * updated the props documentation * updated props naming convention * enhance aws-events-rule-lambda to support custom eventbus * refactoring & enhanced aws-events-rule-sns to support custom eventbus * update viperlight to fix the test * Address PR comments Co-authored-by: santhosh <>
1 parent 9b985fc commit 47221d9

29 files changed

+4648
-119
lines changed

.viperlightignore

+2-2
Original file line numberDiff line numberDiff line change
@@ -28,8 +28,8 @@ source/patterns/@aws-solutions-constructs/aws-lambda-sqs-lambda/test/lambda-sqs-
2828
source/patterns/@aws-solutions-constructs/aws-lambda-sqs-lambda/test/lambda-sqs-lambda.test.ts:67
2929
source/patterns/@aws-solutions-constructs/aws-lambda-step-function/test/lambda-step-function.test.ts:130
3030
source/patterns/@aws-solutions-constructs/aws-lambda-stepfunctions/test/lambda-stepfunctions.test.ts:130
31-
source/patterns/@aws-solutions-constructs/aws-events-rule-sns/test/events-rule-sns-topic.test.ts:243
32-
source/patterns/@aws-solutions-constructs/aws-eventbridge-sns/test/eventbridge-sns-topic.test.ts:243
31+
source/patterns/@aws-solutions-constructs/aws-events-rule-sns/test/events-rule-sns-topic.test.ts:255
32+
source/patterns/@aws-solutions-constructs/aws-eventbridge-sns/test/eventbridge-sns-topic.test.ts:255
3333
source/patterns/@aws-solutions-constructs/aws-events-rule-sqs/test/events-rule-sqs-queue.test.ts:131
3434
source/patterns/@aws-solutions-constructs/aws-eventbridge-sqs/test/eventbridge-sqs-queue.test.ts:131
3535
source/patterns/@aws-solutions-constructs/aws-dynamodb-stream-lambda/test/dynamodb-stream-lambda.test.ts:105

source/patterns/@aws-solutions-constructs/aws-eventbridge-lambda/lib/index.ts

+5-5
Original file line numberDiff line numberDiff line change
@@ -28,31 +28,31 @@ export interface EventbridgeToLambdaProps {
2828
*
2929
* @default - None
3030
*/
31-
readonly existingLambdaObj?: lambda.Function,
31+
readonly existingLambdaObj?: lambda.Function;
3232
/**
3333
* User provided props to override the default props for the Lambda function.
3434
*
3535
* @default - Default props are used
3636
*/
37-
readonly lambdaFunctionProps?: lambda.FunctionProps,
37+
readonly lambdaFunctionProps?: lambda.FunctionProps;
3838
/**
3939
* Existing instance of a custom EventBus.
4040
*
4141
* @default - None
4242
*/
43-
readonly existingEventBusInterface?: events.IEventBus,
43+
readonly existingEventBusInterface?: events.IEventBus;
4444
/**
4545
* A new custom EventBus is created with provided props.
4646
*
4747
* @default - None
4848
*/
49-
readonly eventBusProps?: events.EventBusProps,
49+
readonly eventBusProps?: events.EventBusProps;
5050
/**
5151
* User provided eventRuleProps to override the defaults
5252
*
5353
* @default - None
5454
*/
55-
readonly eventRuleProps: events.RuleProps
55+
readonly eventRuleProps: events.RuleProps;
5656
}
5757

5858
export class EventbridgeToLambda extends Construct {

0 commit comments

Comments
 (0)