update unittest for the construct to reflect v1.87 changes

tabdunabi · tabdunabi · commit 5e9fd5353c93 · 2021-02-17T17:57:51.000-05:00
diff --git a/source/patterns/@aws-solutions-constructs/aws-lambda-sagemakerendpoint/test/__snapshots__/aws-lambda-sagemakerendpoint.test.js.snap b/source/patterns/@aws-solutions-constructs/aws-lambda-sagemakerendpoint/test/__snapshots__/aws-lambda-sagemakerendpoint.test.js.snap
@@ -560,7 +560,7 @@ Object {
     },
   },
   "Resources": Object {
-    "ReplaceEndpointDefaultSecurityGroupCF0CCAF1": Object {
+    "ReplaceEndpointDefaultSecurityGroupsecuritygroupB97DD1AF": Object {
       "Metadata": Object {
         "cfn_nag": Object {
           "rules_to_suppress": Array [
@@ -576,7 +576,7 @@ Object {
         },
       },
       "Properties": Object {
-        "GroupDescription": "Default/ReplaceEndpointDefaultSecurityGroup",
+        "GroupDescription": "Default/ReplaceEndpointDefaultSecurityGroup-security-group",
         "SecurityGroupEgress": Array [
           Object {
             "CidrIp": "0.0.0.0/0",
@@ -775,7 +775,7 @@ Object {
         "SecurityGroupIds": Array [
           Object {
             "Fn::GetAtt": Array [
-              "ReplaceEndpointDefaultSecurityGroupCF0CCAF1",
+              "ReplaceEndpointDefaultSecurityGroupsecuritygroupB97DD1AF",
               "GroupId",
             ],
           },
@@ -1054,7 +1054,7 @@ Object {
           "SecurityGroupIds": Array [
             Object {
               "Fn::GetAtt": Array [
-                "testlambdasagemakerReplaceDefaultSecurityGroup8B1F22EE",
+                "testlambdasagemakerReplaceDefaultSecurityGroupsecuritygroupB2FD7810",
                 "GroupId",
               ],
             },
@@ -1178,7 +1178,7 @@ Object {
       },
       "Type": "AWS::IAM::Policy",
     },
-    "testlambdasagemakerReplaceDefaultSecurityGroup8B1F22EE": Object {
+    "testlambdasagemakerReplaceDefaultSecurityGroupsecuritygroupB2FD7810": Object {
       "Metadata": Object {
         "cfn_nag": Object {
           "rules_to_suppress": Array [
@@ -1194,7 +1194,7 @@ Object {
         },
       },
       "Properties": Object {
-        "GroupDescription": "Default/test-lambda-sagemaker/ReplaceDefaultSecurityGroup",
+        "GroupDescription": "Default/test-lambda-sagemaker/ReplaceDefaultSecurityGroup-security-group",
         "SecurityGroupEgress": Array [
           Object {
             "CidrIp": "0.0.0.0/0",
diff --git a/source/patterns/@aws-solutions-constructs/aws-lambda-sagemakerendpoint/test/aws-lambda-sagemakerendpoint.test.ts b/source/patterns/@aws-solutions-constructs/aws-lambda-sagemakerendpoint/test/aws-lambda-sagemakerendpoint.test.ts
@@ -57,7 +57,7 @@ test('Pattern deployment with new Lambda function, new Sagemaker endpoint, deplo
     VpcConfig: {
       SecurityGroupIds: [
         {
-          'Fn::GetAtt': ['testlambdasagemakerReplaceDefaultSecurityGroup8B1F22EE', 'GroupId'],
+          'Fn::GetAtt': ['testlambdasagemakerReplaceDefaultSecurityGroupsecuritygroupB2FD7810', 'GroupId'],
         },
       ],
       SubnetIds: [
diff --git a/source/patterns/@aws-solutions-constructs/aws-lambda-sagemakerendpoint/test/integ.deployFunctionWithVPCandCustomRole.expected.json b/source/patterns/@aws-solutions-constructs/aws-lambda-sagemakerendpoint/test/integ.deployFunctionWithVPCandCustomRole.expected.json
@@ -324,10 +324,10 @@
         }
       }
     },
-    "testlambdasagemakerReplaceDefaultSecurityGroup8B1F22EE": {
+    "testlambdasagemakerReplaceDefaultSecurityGroupsecuritygroupB2FD7810": {
       "Type": "AWS::EC2::SecurityGroup",
       "Properties": {
-        "GroupDescription": "test-lambda-sagemakerendpoint/test-lambda-sagemaker/ReplaceDefaultSecurityGroup",
+        "GroupDescription": "test-lambda-sagemakerendpoint/test-lambda-sagemaker/ReplaceDefaultSecurityGroup-security-group",
         "SecurityGroupEgress": [
           {
             "CidrIp": "0.0.0.0/0",
@@ -422,7 +422,7 @@
           "SecurityGroupIds": [
             {
               "Fn::GetAtt": [
-                "testlambdasagemakerReplaceDefaultSecurityGroup8B1F22EE",
+                "testlambdasagemakerReplaceDefaultSecurityGroupsecuritygroupB2FD7810",
                 "GroupId"
               ]
             }
@@ -781,7 +781,7 @@
         "SecurityGroupIds": [
           {
             "Fn::GetAtt": [
-              "ReplaceEndpointDefaultSecurityGroupCF0CCAF1",
+              "ReplaceEndpointDefaultSecurityGroupsecuritygroupB97DD1AF",
               "GroupId"
             ]
           }
@@ -800,10 +800,10 @@
         "VpcEndpointType": "Interface"
       }
     },
-    "ReplaceEndpointDefaultSecurityGroupCF0CCAF1": {
+    "ReplaceEndpointDefaultSecurityGroupsecuritygroupB97DD1AF": {
       "Type": "AWS::EC2::SecurityGroup",
       "Properties": {
-        "GroupDescription": "test-lambda-sagemakerendpoint/ReplaceEndpointDefaultSecurityGroup",
+        "GroupDescription": "test-lambda-sagemakerendpoint/ReplaceEndpointDefaultSecurityGroup-security-group",
         "SecurityGroupEgress": [
           {
             "CidrIp": "0.0.0.0/0",
diff --git a/source/patterns/@aws-solutions-constructs/aws-lambda-sagemakerendpoint/test/integ.deployFunctionWithVpc.expected.json b/source/patterns/@aws-solutions-constructs/aws-lambda-sagemakerendpoint/test/integ.deployFunctionWithVpc.expected.json
@@ -550,10 +550,10 @@
         }
       }
     },
-    "testlambdasagemakerReplaceDefaultSecurityGroup8B1F22EE": {
+    "testlambdasagemakerReplaceDefaultSecurityGroupsecuritygroupB2FD7810": {
       "Type": "AWS::EC2::SecurityGroup",
       "Properties": {
-        "GroupDescription": "test-lambda-sagemakerendpoint/test-lambda-sagemaker/ReplaceDefaultSecurityGroup",
+        "GroupDescription": "test-lambda-sagemakerendpoint/test-lambda-sagemaker/ReplaceDefaultSecurityGroup-security-group",
         "SecurityGroupEgress": [
           {
             "CidrIp": "0.0.0.0/0",
@@ -648,7 +648,7 @@
           "SecurityGroupIds": [
             {
               "Fn::GetAtt": [
-                "testlambdasagemakerReplaceDefaultSecurityGroup8B1F22EE",
+                "testlambdasagemakerReplaceDefaultSecurityGroupsecuritygroupB2FD7810",
                 "GroupId"
               ]
             }
@@ -1007,7 +1007,7 @@
         "SecurityGroupIds": [
           {
             "Fn::GetAtt": [
-              "ReplaceEndpointDefaultSecurityGroupCF0CCAF1",
+              "ReplaceEndpointDefaultSecurityGroupsecuritygroupB97DD1AF",
               "GroupId"
             ]
           }
@@ -1026,10 +1026,10 @@
         "VpcEndpointType": "Interface"
       }
     },
-    "ReplaceEndpointDefaultSecurityGroupCF0CCAF1": {
+    "ReplaceEndpointDefaultSecurityGroupsecuritygroupB97DD1AF": {
       "Type": "AWS::EC2::SecurityGroup",
       "Properties": {
-        "GroupDescription": "test-lambda-sagemakerendpoint/ReplaceEndpointDefaultSecurityGroup",
+        "GroupDescription": "test-lambda-sagemakerendpoint/ReplaceEndpointDefaultSecurityGroup-security-group",
         "SecurityGroupEgress": [
           {
             "CidrIp": "0.0.0.0/0",
diff --git a/source/patterns/@aws-solutions-constructs/aws-lambda-sagemakerendpoint/test/integ.deployFunctionWithexistingVpc.expected.json b/source/patterns/@aws-solutions-constructs/aws-lambda-sagemakerendpoint/test/integ.deployFunctionWithexistingVpc.expected.json
@@ -715,7 +715,7 @@
         "SecurityGroupIds": [
           {
             "Fn::GetAtt": [
-              "ReplaceEndpointDefaultSecurityGroupCF0CCAF1",
+              "ReplaceEndpointDefaultSecurityGroupsecuritygroupB97DD1AF",
               "GroupId"
             ]
           }
@@ -734,10 +734,10 @@
         "VpcEndpointType": "Interface"
       }
     },
-    "ReplaceEndpointDefaultSecurityGroupCF0CCAF1": {
+    "ReplaceEndpointDefaultSecurityGroupsecuritygroupB97DD1AF": {
       "Type": "AWS::EC2::SecurityGroup",
       "Properties": {
-        "GroupDescription": "test-lambda-sagemakerendpoint/ReplaceEndpointDefaultSecurityGroup",
+        "GroupDescription": "test-lambda-sagemakerendpoint/ReplaceEndpointDefaultSecurityGroup-security-group",
         "SecurityGroupEgress": [
           {
             "CidrIp": "0.0.0.0/0",
@@ -1341,10 +1341,10 @@
         }
       }
     },
-    "testlambdasagemakerReplaceDefaultSecurityGroup8B1F22EE": {
+    "testlambdasagemakerReplaceDefaultSecurityGroupsecuritygroupB2FD7810": {
       "Type": "AWS::EC2::SecurityGroup",
       "Properties": {
-        "GroupDescription": "test-lambda-sagemakerendpoint/test-lambda-sagemaker/ReplaceDefaultSecurityGroup",
+        "GroupDescription": "test-lambda-sagemakerendpoint/test-lambda-sagemaker/ReplaceDefaultSecurityGroup-security-group",
         "SecurityGroupEgress": [
           {
             "CidrIp": "0.0.0.0/0",
@@ -1439,7 +1439,7 @@
           "SecurityGroupIds": [
             {
               "Fn::GetAtt": [
-                "testlambdasagemakerReplaceDefaultSecurityGroup8B1F22EE",
+                "testlambdasagemakerReplaceDefaultSecurityGroupsecuritygroupB2FD7810",
                 "GroupId"
               ]
             }

Original file line number	Diff line number	Diff line change
`@@ -57,7 +57,7 @@ test('Pattern deployment with new Lambda function, new Sagemaker endpoint, deplo`
`57`	`57`	`VpcConfig: {`
`58`	`58`	`SecurityGroupIds: [`
`59`	`59`	`{`
`60`		`- 'Fn::GetAtt': ['testlambdasagemakerReplaceDefaultSecurityGroup8B1F22EE', 'GroupId'],`
	`60`	`+ 'Fn::GetAtt': ['testlambdasagemakerReplaceDefaultSecurityGroupsecuritygroupB2FD7810', 'GroupId'],`
`61`	`61`	`},`
`62`	`62`	`],`
`63`	`63`	`SubnetIds: [`
Original file line number	Diff line number	Diff line change
`@@ -324,10 +324,10 @@`
`324`	`324`	`}`
`325`	`325`	`}`
`326`	`326`	`},`
`327`		`- "testlambdasagemakerReplaceDefaultSecurityGroup8B1F22EE": {`
	`327`	`+ "testlambdasagemakerReplaceDefaultSecurityGroupsecuritygroupB2FD7810": {`
`328`	`328`	`"Type": "AWS::EC2::SecurityGroup",`
`329`	`329`	`"Properties": {`
`330`		`- "GroupDescription": "test-lambda-sagemakerendpoint/test-lambda-sagemaker/ReplaceDefaultSecurityGroup",`
	`330`	`+ "GroupDescription": "test-lambda-sagemakerendpoint/test-lambda-sagemaker/ReplaceDefaultSecurityGroup-security-group",`
`331`	`331`	`"SecurityGroupEgress": [`
`332`	`332`	`{`
`333`	`333`	`"CidrIp": "0.0.0.0/0",`
`@@ -422,7 +422,7 @@`
`422`	`422`	`"SecurityGroupIds": [`
`423`	`423`	`{`
`424`	`424`	`"Fn::GetAtt": [`
`425`		`- "testlambdasagemakerReplaceDefaultSecurityGroup8B1F22EE",`
	`425`	`+ "testlambdasagemakerReplaceDefaultSecurityGroupsecuritygroupB2FD7810",`
`426`	`426`	`"GroupId"`
`427`	`427`	`]`
`428`	`428`	`}`
`@@ -781,7 +781,7 @@`
`781`	`781`	`"SecurityGroupIds": [`
`782`	`782`	`{`
`783`	`783`	`"Fn::GetAtt": [`
`784`		`- "ReplaceEndpointDefaultSecurityGroupCF0CCAF1",`
	`784`	`+ "ReplaceEndpointDefaultSecurityGroupsecuritygroupB97DD1AF",`
`785`	`785`	`"GroupId"`
`786`	`786`	`]`
`787`	`787`	`}`
`@@ -800,10 +800,10 @@`
`800`	`800`	`"VpcEndpointType": "Interface"`
`801`	`801`	`}`
`802`	`802`	`},`
`803`		`- "ReplaceEndpointDefaultSecurityGroupCF0CCAF1": {`
	`803`	`+ "ReplaceEndpointDefaultSecurityGroupsecuritygroupB97DD1AF": {`
`804`	`804`	`"Type": "AWS::EC2::SecurityGroup",`
`805`	`805`	`"Properties": {`
`806`		`- "GroupDescription": "test-lambda-sagemakerendpoint/ReplaceEndpointDefaultSecurityGroup",`
	`806`	`+ "GroupDescription": "test-lambda-sagemakerendpoint/ReplaceEndpointDefaultSecurityGroup-security-group",`
`807`	`807`	`"SecurityGroupEgress": [`
`808`	`808`	`{`
`809`	`809`	`"CidrIp": "0.0.0.0/0",`
Original file line number	Diff line number	Diff line change
`@@ -550,10 +550,10 @@`
`550`	`550`	`}`
`551`	`551`	`}`
`552`	`552`	`},`
`553`		`- "testlambdasagemakerReplaceDefaultSecurityGroup8B1F22EE": {`
	`553`	`+ "testlambdasagemakerReplaceDefaultSecurityGroupsecuritygroupB2FD7810": {`
`554`	`554`	`"Type": "AWS::EC2::SecurityGroup",`
`555`	`555`	`"Properties": {`
`556`		`- "GroupDescription": "test-lambda-sagemakerendpoint/test-lambda-sagemaker/ReplaceDefaultSecurityGroup",`
	`556`	`+ "GroupDescription": "test-lambda-sagemakerendpoint/test-lambda-sagemaker/ReplaceDefaultSecurityGroup-security-group",`
`557`	`557`	`"SecurityGroupEgress": [`
`558`	`558`	`{`
`559`	`559`	`"CidrIp": "0.0.0.0/0",`
`@@ -648,7 +648,7 @@`
`648`	`648`	`"SecurityGroupIds": [`
`649`	`649`	`{`
`650`	`650`	`"Fn::GetAtt": [`
`651`		`- "testlambdasagemakerReplaceDefaultSecurityGroup8B1F22EE",`
	`651`	`+ "testlambdasagemakerReplaceDefaultSecurityGroupsecuritygroupB2FD7810",`
`652`	`652`	`"GroupId"`
`653`	`653`	`]`
`654`	`654`	`}`
`@@ -1007,7 +1007,7 @@`
`1007`	`1007`	`"SecurityGroupIds": [`
`1008`	`1008`	`{`
`1009`	`1009`	`"Fn::GetAtt": [`
`1010`		`- "ReplaceEndpointDefaultSecurityGroupCF0CCAF1",`
	`1010`	`+ "ReplaceEndpointDefaultSecurityGroupsecuritygroupB97DD1AF",`
`1011`	`1011`	`"GroupId"`
`1012`	`1012`	`]`
`1013`	`1013`	`}`
`@@ -1026,10 +1026,10 @@`
`1026`	`1026`	`"VpcEndpointType": "Interface"`
`1027`	`1027`	`}`
`1028`	`1028`	`},`
`1029`		`- "ReplaceEndpointDefaultSecurityGroupCF0CCAF1": {`
	`1029`	`+ "ReplaceEndpointDefaultSecurityGroupsecuritygroupB97DD1AF": {`
`1030`	`1030`	`"Type": "AWS::EC2::SecurityGroup",`
`1031`	`1031`	`"Properties": {`
`1032`		`- "GroupDescription": "test-lambda-sagemakerendpoint/ReplaceEndpointDefaultSecurityGroup",`
	`1032`	`+ "GroupDescription": "test-lambda-sagemakerendpoint/ReplaceEndpointDefaultSecurityGroup-security-group",`
`1033`	`1033`	`"SecurityGroupEgress": [`
`1034`	`1034`	`{`
`1035`	`1035`	`"CidrIp": "0.0.0.0/0",`
Original file line number	Diff line number	Diff line change
`@@ -715,7 +715,7 @@`
`715`	`715`	`"SecurityGroupIds": [`
`716`	`716`	`{`
`717`	`717`	`"Fn::GetAtt": [`
`718`		`- "ReplaceEndpointDefaultSecurityGroupCF0CCAF1",`
	`718`	`+ "ReplaceEndpointDefaultSecurityGroupsecuritygroupB97DD1AF",`
`719`	`719`	`"GroupId"`
`720`	`720`	`]`
`721`	`721`	`}`
`@@ -734,10 +734,10 @@`
`734`	`734`	`"VpcEndpointType": "Interface"`
`735`	`735`	`}`
`736`	`736`	`},`
`737`		`- "ReplaceEndpointDefaultSecurityGroupCF0CCAF1": {`
	`737`	`+ "ReplaceEndpointDefaultSecurityGroupsecuritygroupB97DD1AF": {`
`738`	`738`	`"Type": "AWS::EC2::SecurityGroup",`
`739`	`739`	`"Properties": {`
`740`		`- "GroupDescription": "test-lambda-sagemakerendpoint/ReplaceEndpointDefaultSecurityGroup",`
	`740`	`+ "GroupDescription": "test-lambda-sagemakerendpoint/ReplaceEndpointDefaultSecurityGroup-security-group",`
`741`	`741`	`"SecurityGroupEgress": [`
`742`	`742`	`{`
`743`	`743`	`"CidrIp": "0.0.0.0/0",`
`@@ -1341,10 +1341,10 @@`
`1341`	`1341`	`}`
`1342`	`1342`	`}`
`1343`	`1343`	`},`
`1344`		`- "testlambdasagemakerReplaceDefaultSecurityGroup8B1F22EE": {`
	`1344`	`+ "testlambdasagemakerReplaceDefaultSecurityGroupsecuritygroupB2FD7810": {`
`1345`	`1345`	`"Type": "AWS::EC2::SecurityGroup",`
`1346`	`1346`	`"Properties": {`
`1347`		`- "GroupDescription": "test-lambda-sagemakerendpoint/test-lambda-sagemaker/ReplaceDefaultSecurityGroup",`
	`1347`	`+ "GroupDescription": "test-lambda-sagemakerendpoint/test-lambda-sagemaker/ReplaceDefaultSecurityGroup-security-group",`
`1348`	`1348`	`"SecurityGroupEgress": [`
`1349`	`1349`	`{`
`1350`	`1350`	`"CidrIp": "0.0.0.0/0",`
`@@ -1439,7 +1439,7 @@`
`1439`	`1439`	`"SecurityGroupIds": [`
`1440`	`1440`	`{`
`1441`	`1441`	`"Fn::GetAtt": [`
`1442`		`- "testlambdasagemakerReplaceDefaultSecurityGroup8B1F22EE",`
	`1442`	`+ "testlambdasagemakerReplaceDefaultSecurityGroupsecuritygroupB2FD7810",`
`1443`	`1443`	`"GroupId"`
`1444`	`1444`	`]`
`1445`	`1445`	`}`