Skip to content

Commit 69f7fbd

Browse files
authored
Merge pull request #197 from knihit/master
Fix for Issue #196. Changed S3 protocol to use s3a:// for storing transformed output data BREAKING CHANGE: any testing snapshots will need to be refreshed.
2 parents fcd9d30 + 5baa256 commit 69f7fbd

File tree

8 files changed

+498
-492
lines changed

8 files changed

+498
-492
lines changed

.viperlightignore

+2
Original file line numberDiff line numberDiff line change
@@ -121,3 +121,5 @@ source/patterns/@aws-solutions-constructs/aws-lambda-sagemakerendpoint/test/test
121121
source/patterns/@aws-solutions-constructs/aws-lambda-sagemakerendpoint/test/test-helper.ts:78
122122
source/patterns/@aws-solutions-constructs/aws-lambda-sagemakerendpoint/test/test-helper.ts:81
123123
source/patterns/@aws-solutions-constructs/aws-lambda-sagemakerendpoint/test/test-helper.ts:84
124+
# This is a test case
125+
source/patterns/@aws-solutions-constructs/aws-kinesisstreams-gluejob/test/test.kinesisstream-gluejob.test.ts:129

source/patterns/@aws-solutions-constructs/aws-kinesisstreams-gluejob/lib/index.ts

+4-3
Original file line numberDiff line numberDiff line change
@@ -156,7 +156,7 @@ export class KinesisstreamsToGluejob extends Construct {
156156
outputDataStore: props.outputDataStore!
157157
});
158158

159-
this.glueJobRole = this.buildRolePolicy(scope, this.database, this.table, this.glueJob, this.glueJobRole);
159+
this.glueJobRole = this.buildRolePolicy(scope, id, this.database, this.table, this.glueJob, this.glueJobRole);
160160
}
161161

162162
/**
@@ -168,8 +168,9 @@ export class KinesisstreamsToGluejob extends Construct {
168168
* @param glueJob
169169
* @param role
170170
*/
171-
private buildRolePolicy(scope: Construct, glueDatabase: glue.CfnDatabase, glueTable: glue.CfnTable, glueJob: glue.CfnJob, role: IRole): IRole {
172-
const _glueJobPolicy = new Policy(scope, 'GlueJobPolicy', {
171+
private buildRolePolicy(scope: Construct, id: string, glueDatabase: glue.CfnDatabase, glueTable: glue.CfnTable,
172+
glueJob: glue.CfnJob, role: IRole): IRole {
173+
const _glueJobPolicy = new Policy(scope, `${id}GlueJobPolicy`, {
173174
statements: [ new PolicyStatement({
174175
effect: Effect.ALLOW,
175176
actions: [ 'glue:GetJob' ],

0 commit comments

Comments
 (0)