Skip to content

Commit 9812468

Browse files
knihitknihit
authored
Fixed a key name typo for Glue table properties for issue #184 (#185)
* initial commit for construct * initial commit for construct * adding a new construct * updates to construct default glue attributes * updating package.json * updating ts files * adding unit tests and integ tests * adding unit tests and integ tests * adding unit tests and helper methods to complete the construct * adding unit tests * adding unit tests * adding unit tests * fix for linting error * adding glue job example * update readme.md * update snapshots and kms arn * update description in package.json * integ test cases * added simulator for kinesis stream * added simulator for kinesis stream * integ test cases * updating construct for scriptlocation * updating python generator file * updating example code * updating example code * updating example code * updating example code * updating example code * updating example code * updating example code * update README and Architecture * updating README * updating README * updating construct * updating construct * updating construct * updating construct * updating construct * updating construct * updating construct * updating construct * updating construct * updating sample * updating construct * updating construct * updating construct * updating construct * updating sample * updating sample * updating construct kinesis policy * updating construct kinesis policy * updating construct kinesis policy * updating construct kinesis policy * updating construct kinesis policy * updating construct kinesis policy * updating construct kinesis policy * updating construct * updating construct kinesis policy * updating construct kinesis policy * updating construct kinesis policy * updating construct kinesis policy * updating construct policy * updating readme * updated README * updated README * updated README * updated README * updated README * updated README * updated README * updated README * updated README * updates based on review * incoporating review comments * incoporating review comments * incoporating review comments * incoporating review comments * incoporating review comments * update to construct * update to construct * update to construct * update to construct * update to construct * update to construct * refactoring code to match construct patterns * refactoring code to match construct patterns * refactoring code to match construct patterns * refactoring code to match construct patterns * refactoring code to match construct patterns * refactoring code to match construct patterns * refactoring code to match construct patterns * fix for readme file * eslint fixes * update sample after refactoring construct * update sample after refactoring construct * remove _ from variable names * updating glue version 2.0 as recommended in Glue service documentation * removed snapshot (that was not required) to fix build failure * update viperlight to fix build issue * update viperlight to fix build issue * cfn_nag fix for build issues * updating integ snapshots * updating integ snapshots * update header * update header * incorporate publisher review comments * incorporate publisher review comments * incorporate publisher review comments * reorganization unitt tests * reorganization unitt tests * reorganization unitt tests * reorganization unitt tests * reorganization unitt tests * reorganization unitt tests * incorporate review comments * fix for output s3 bucket * fix for output s3 bucket * fix for output s3 bucket * update README with the correct class name * updating README * updates to readme * updates to readme * updates to readme * updates to readme * removing duplicate words from README * fix for bug #184 * fix for bug #184 * fix for bug #184 Co-authored-by: nihitkas <[email protected]>
1 parent b0567e4 commit 9812468

File tree

8 files changed

+18
-18
lines changed

8 files changed

+18
-18
lines changed

‎source/patterns/@aws-solutions-constructs/aws-kinesisstreams-gluejob/test/__snapshots__/test.kinesisstream-gluejob.test.js.snap

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -188,7 +188,7 @@ Object {
188188
},
189189
"TableInput": Object {
190190
"Parameters": Object {
191-
"classication": "json",
191+
"classification": "json",
192192
},
193193
"StorageDescriptor": Object {
194194
"Columns": Array [
@@ -866,7 +866,7 @@ Object {
866866
},
867867
"TableInput": Object {
868868
"Parameters": Object {
869-
"classication": "json",
869+
"classification": "json",
870870
},
871871
"StorageDescriptor": Object {
872872
"Columns": Array [
@@ -1149,7 +1149,7 @@ Object {
11491149
},
11501150
"TableInput": Object {
11511151
"Parameters": Object {
1152-
"classication": "json",
1152+
"classification": "json",
11531153
},
11541154
"StorageDescriptor": Object {
11551155
"Columns": Array [
@@ -1787,7 +1787,7 @@ Object {
17871787
},
17881788
"TableInput": Object {
17891789
"Parameters": Object {
1790-
"classication": "json",
1790+
"classification": "json",
17911791
},
17921792
"StorageDescriptor": Object {
17931793
"Columns": Array [
@@ -2412,7 +2412,7 @@ Object {
24122412
},
24132413
"TableInput": Object {
24142414
"Parameters": Object {
2415-
"classication": "json",
2415+
"classification": "json",
24162416
},
24172417
"StorageDescriptor": Object {
24182418
"Columns": Array [
@@ -3063,7 +3063,7 @@ Object {
30633063
},
30643064
"TableInput": Object {
30653065
"Parameters": Object {
3066-
"classication": "json",
3066+
"classification": "json",
30673067
},
30683068
"StorageDescriptor": Object {
30693069
"Columns": Array [

‎source/patterns/@aws-solutions-constructs/aws-kinesisstreams-gluejob/test/integ.existing-job.expected.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -105,7 +105,7 @@
105105
},
106106
"TableInput": {
107107
"Parameters": {
108-
"classication": "json"
108+
"classification": "json"
109109
},
110110
"StorageDescriptor": {
111111
"Columns": [

‎source/patterns/@aws-solutions-constructs/aws-kinesisstreams-gluejob/test/integ.no-arguments.expected.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -519,7 +519,7 @@
519519
},
520520
"TableInput": {
521521
"Parameters": {
522-
"classication": "json"
522+
"classification": "json"
523523
},
524524
"StorageDescriptor": {
525525
"Columns": [

‎source/patterns/@aws-solutions-constructs/aws-kinesisstreams-gluejob/test/test.kinesisstream-gluejob.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -602,7 +602,7 @@ test('When database and table are not provided', () => {
602602
},
603603
TableInput: {
604604
Parameters: {
605-
classication: "json"
605+
classification: "json"
606606
},
607607
StorageDescriptor: {
608608
Columns: [

‎source/patterns/@aws-solutions-constructs/core/lib/glue-table-defaults.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
import * as glue from "@aws-cdk/aws-glue";
1515
import { Aws } from "@aws-cdk/core";
1616

17-
export function DefaultGlueTableProps(database: glue.CfnDatabase, fieldSchema: glue.CfnTable.ColumnProperty [],
17+
export function DefaultGlueTableProps(database: glue.CfnDatabase, fieldSchema: glue.CfnTable.ColumnProperty[],
1818
sourceType?: string, parameters?: any): glue.CfnTableProps | any {
1919
let _tableProps: glue.CfnTableProps;
2020

@@ -50,7 +50,7 @@ export function DefaultGlueTableProps(database: glue.CfnDatabase, fieldSchema: g
5050
},
5151
tableType: 'EXTERNAL_TABLE',
5252
parameters: {
53-
classication: 'json'
53+
classification: 'json'
5454
}
5555
}
5656
};

‎source/patterns/@aws-solutions-constructs/core/test/__snapshots__/glue-job-helper.test.js.snap

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ Object {
6363
},
6464
"TableInput": Object {
6565
"Parameters": Object {
66-
"classication": "json",
66+
"classification": "json",
6767
},
6868
"StorageDescriptor": Object {
6969
"Columns": Array [
@@ -188,7 +188,7 @@ Object {
188188
},
189189
"TableInput": Object {
190190
"Parameters": Object {
191-
"classication": "json",
191+
"classification": "json",
192192
},
193193
"StorageDescriptor": Object {
194194
"Columns": Array [
@@ -645,7 +645,7 @@ Object {
645645
},
646646
"TableInput": Object {
647647
"Parameters": Object {
648-
"classication": "json",
648+
"classification": "json",
649649
},
650650
"StorageDescriptor": Object {
651651
"Columns": Array [
@@ -1117,7 +1117,7 @@ Object {
11171117
},
11181118
"TableInput": Object {
11191119
"Parameters": Object {
1120-
"classication": "json",
1120+
"classification": "json",
11211121
},
11221122
"StorageDescriptor": Object {
11231123
"Columns": Array [
@@ -1561,7 +1561,7 @@ Object {
15611561
},
15621562
"TableInput": Object {
15631563
"Parameters": Object {
1564-
"classication": "json",
1564+
"classification": "json",
15651565
},
15661566
"StorageDescriptor": Object {
15671567
"Columns": Array [

‎source/patterns/@aws-solutions-constructs/core/test/__snapshots__/glue-table-helper.test.js.snap

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ Object {
2424
},
2525
"TableInput": Object {
2626
"Parameters": Object {
27-
"classication": "json",
27+
"classification": "json",
2828
},
2929
"StorageDescriptor": Object {
3030
"Columns": Array [

‎source/patterns/@aws-solutions-constructs/core/test/glue-table-helper.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -121,7 +121,7 @@ test('Create table', () => {
121121
},
122122
TableInput: {
123123
Parameters: {
124-
classication: "json"
124+
classification: "json"
125125
},
126126
StorageDescriptor: {
127127
Columns: [

0 commit comments

Comments
 (0)