Skip to content

Commit c1fffb3

Browse files
committed
test - address some typos
1 parent b6e19f5 commit c1fffb3

File tree

2 files changed

+3
-42
lines changed

2 files changed

+3
-42
lines changed

source/patterns/@aws-solutions-constructs/aws-lambda-sagemakerendpoint/package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@
5555
"dependencies": {
5656
"@aws-cdk/aws-ec2": "0.0.0",
5757
"@aws-cdk/aws-s3": "0.0.0",
58-
"@aws-cdk/aws-s3-deployment": "0.0.0",
58+
"@aws-cdk/aws-s3-assets": "0.0.0",
5959
"@aws-cdk/aws-iam": "0.0.0",
6060
"@aws-cdk/aws-lambda": "0.0.0",
6161
"@aws-cdk/aws-sagemaker": "0.0.0",
@@ -85,7 +85,7 @@
8585
"peerDependencies": {
8686
"@aws-cdk/aws-ec2": "0.0.0",
8787
"@aws-cdk/aws-s3": "0.0.0",
88-
"@aws-cdk/aws-s3-deployment": "0.0.0",
88+
"@aws-cdk/aws-s3-assets": "0.0.0",
8989
"@aws-cdk/aws-iam": "0.0.0",
9090
"@aws-cdk/aws-lambda": "0.0.0",
9191
"@aws-cdk/aws-sagemaker": "0.0.0",

source/patterns/@aws-solutions-constructs/aws-lambda-sagemakerendpoint/test/test-helper.ts

Lines changed: 1 addition & 40 deletions
Original file line numberDiff line numberDiff line change
@@ -11,11 +11,8 @@
1111
* and limitations under the License.
1212
*/
1313

14-
// import * as s3 from '@aws-cdk/aws-s3';
15-
// import * as lambda from '@aws-cdk/aws-lambda';
1614
import * as s3a from '@aws-cdk/aws-s3-assets';
1715
import { Stack, CfnMapping } from '@aws-cdk/core';
18-
// import { CreateScrapBucket } from '@aws-solutions-constructs/core';
1916

2017
// linear learner ECR images can be found here:
2118
// https://github.com/awsdocs/amazon-sagemaker-developer-guide/blob/master/doc_source/sagemaker-algo-docker-registry-paths.md
@@ -89,46 +86,10 @@ export function getSagemakerModel(stack: Stack): [CfnMapping, s3a.Asset ] {
8986
}
9087
});
9188

92-
// const sourceBucket = new s3.Bucket(stack, 'source-bucket', {
93-
// removalPolicy: RemovalPolicy.DESTROY,
94-
// autoDeleteObjects: true
95-
// });
96-
97-
// const sourceBucket = CreateScrapBucket(stack, { autoDeleteObjects: true });
98-
99-
// const customResourceLambda = stack.node.findChild('Custom::S3AutoDeleteObjectsCustomResourceProvider').node.findChild('Handler') as lambda.CfnFunction;
100-
101-
// customResourceLambda.cfnOptions.metadata = {
102-
// cfn_nag: {
103-
// rules_to_suppress: [{
104-
// id: 'W58',
105-
// reason: `Lambda functions has the required permission to write CloudWatch Logs. It uses custom policy instead of arn:aws:iam::aws:policy/service-role/AWSLambdaBasicExecutionRole with tighter permissions.`
106-
// },
107-
// {
108-
// id: 'W89',
109-
// reason: `This is not a rule for the general case, just for specific use cases/industries`
110-
// },
111-
// {
112-
// id: 'W92',
113-
// reason: `Impossible for us to define the correct concurrency for clients`
114-
// }]
115-
// }
116-
// };
117-
118-
// const modelDeployment = new s3d.BucketDeployment(stack, 'bucket-deployment', {
119-
// destinationBucket: sourceBucket,
120-
// sources: [
121-
// s3d.Source.asset(`${__dirname}/model`)
122-
// ]
123-
// });
124-
125-
// return [containerMap, sourceBucket, modelDeployment];
126-
12789
const modelAsset = new s3a.Asset(stack, 'SampleAsset', {
12890
path: 'model/model.tar.gz',
12991
});
13092

131-
132-
return [containerMap, modelAsset]
93+
return [containerMap, modelAsset];
13394

13495
}

0 commit comments

Comments
 (0)