Skip to content

Commit e4f425d

Browse files
committed
encypted bucket in existing job integ test
1 parent d7d10f6 commit e4f425d

File tree

2 files changed

+16
-5
lines changed

2 files changed

+16
-5
lines changed

source/patterns/@aws-solutions-constructs/aws-kinesisstreams-gluejob/test/integ.existing-job.expected.json

Lines changed: 11 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,15 @@
44
"existingScriptLocation845F3C51": {
55
"Type": "AWS::S3::Bucket",
66
"Properties": {
7+
"BucketEncryption": {
8+
"ServerSideEncryptionConfiguration": [
9+
{
10+
"ServerSideEncryptionByDefault": {
11+
"SSEAlgorithm": "AES256"
12+
}
13+
}
14+
]
15+
},
716
"LifecycleConfiguration": {
817
"Rules": [
918
{
@@ -13,8 +22,8 @@
1322
]
1423
}
1524
},
16-
"UpdateReplacePolicy": "Retain",
17-
"DeletionPolicy": "Retain",
25+
"UpdateReplacePolicy": "Delete",
26+
"DeletionPolicy": "Delete",
1827
"Metadata": {
1928
"cfn_nag": {
2029
"rules_to_suppress": [

source/patterns/@aws-solutions-constructs/aws-kinesisstreams-gluejob/test/integ.existing-job.ts

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,8 @@
1414
// Imports
1515
import { CfnJob } from '@aws-cdk/aws-glue';
1616
import { Role, ServicePrincipal } from '@aws-cdk/aws-iam';
17-
import { Bucket, CfnBucket } from '@aws-cdk/aws-s3';
18-
import { App, Duration, Stack } from '@aws-cdk/core';
17+
import { Bucket, BucketEncryption, CfnBucket } from '@aws-cdk/aws-s3';
18+
import { App, Duration, RemovalPolicy, Stack } from '@aws-cdk/core';
1919
import { generateIntegStackName, SinkStoreType } from '@aws-solutions-constructs/core';
2020
import { KinesisstreamsToGluejob } from '../lib';
2121

@@ -28,7 +28,9 @@ const scriptBucket = new Bucket(stack, 'existingScriptLocation', {
2828
versioned: false,
2929
lifecycleRules: [{
3030
expiration: Duration.days(30)
31-
}]
31+
}],
32+
removalPolicy: RemovalPolicy.DESTROY,
33+
encryption: BucketEncryption.S3_MANAGED
3234
});
3335

3436
(scriptBucket.node.defaultChild as CfnBucket).cfnOptions.metadata = {

0 commit comments

Comments
 (0)