fix(apigateway-helper): fixed condition for cloudWatchRole creation #468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mickychetta
requested review from
biffgaut,
hayesry and
hnishar
as code owners
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
mickychetta
changed the title
biffgaut
requested changes
Oct 20, 2021
| ] | ||
| } | ||
| }); | ||
| expect(stack).toCountResources("AWS::ApiGateway::Account", 0); |
There was a problem hiding this comment.
A little more explicit to use:
expect(stack).not.toHaveResourceLike("AWS::ApiGateway::Account", {});
| cloudWatchRole: false | ||
| }); | ||
|
|
||
| expect(stack).toCountResources("AWS::ApiGateway::Account", 0); |
There was a problem hiding this comment.
Similar change to use the .not. operator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
biffgaut
approved these changes
Oct 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #445, if available:
Description of changes:
-If cloudWatchRole is false then we create no role
-If cloudWatchRole is not false then we create a role using our function (More fine grained role than the CDK)
-Made apiGatewayCloudWatchRole an optional pattern prop since it can be undefined
-Added test to check if no AWS::ApiGateway::Account gets created
-Updated multiple README.md
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
fixes #445