Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update: [SNS Patterns] Allow for existingTopicObj and change default encryption #49

Closed
hnishar opened this issue Aug 26, 2020 · 1 comment
Closed

Update: [SNS Patterns] Allow for existingTopicObj and change default encryption #49

hnishar opened this issue Aug 26, 2020 · 1 comment
Assignees
@hnishar
Labels
enhancement New feature or request

Comments

@hnishar
Copy link
Contributor

hnishar commented Aug 26, 2020

Issue:

Inconsistencies in -SNS- Construct props compared to the other e.g. -SQS-, -S3- patterns

Solution:

  • Allow user to provide existingTopicObj?
  • Change the default server-side encryption for SNS Topic from Customer managed KMS Key to AWS managed KMS Key
@hnishar hnishar added the enhancement New feature or request label Aug 26, 2020
@hnishar hnishar self-assigned this Aug 26, 2020
@hnishar hnishar added in-progress This issue is being actively worked on and removed in-progress This issue is being actively worked on labels Aug 27, 2020
@hnishar
Copy link
Contributor Author

hnishar commented Sep 1, 2020

Pushed out in the latest release v1.61.1

@hnishar hnishar closed this as completed Sep 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hnishar hnishar

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@hnishar