Skip to content

Commit bcb91ae

Browse files
committed
refactor: apply "no-var" rule to source code
1 parent f6135ab commit bcb91ae

File tree

9 files changed

+28
-28
lines changed

9 files changed

+28
-28
lines changed

Diff for: ja/ESLint/README.md

+5-5
Original file line numberDiff line numberDiff line change
@@ -148,22 +148,22 @@ import {EventEmitter} from "events";
148148

149149
function lint(code){
150150
// コードをパースしてASTにする
151-
var ast = parse(code);
151+
let ast = parse(code);
152152
// イベントの登録場所
153-
var emitter = new EventEmitter();
154-
var results = [];
153+
let emitter = new EventEmitter();
154+
let results = [];
155155
emitter.on("report", message => {
156156
// 3. のためのreportされた内容を集める
157157
results.push(message);
158158
});
159159
// 利用するルール一覧
160-
var ruleList = getAllRules();
160+
let ruleList = getAllRules();
161161
// 1. ルール毎に使っている`Node.type`をイベント登録する
162162
ruleList.forEach(rule => {
163163
// それぞれのルールに定義されているメソッド一覧を取得
164164
// e.g) MemberExpression(node){}
165165
// => {"MemberExpression" : function(node){}, ... } というオブジェクト
166-
var methodObject = getDefinedMethod(rule);
166+
let methodObject = getDefinedMethod(rule);
167167
Object.keys(methodObject).forEach(nodeType => {
168168
emitter.on(nodeType, methodList[nodeType]);
169169
});

Diff for: src/ESLint/MyLinter-example.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -5,13 +5,13 @@ import noConsole from "./no-console";
55

66
let linter = new MyLinter();
77
linter.loadRule(noConsole);
8-
var code = `
8+
let code = `
99
function add(x, y){
1010
console.log(x, y);
1111
return x + y;
1212
}
1313
add(1, 3);
1414
`;
15-
var results = linter.lint(code);
15+
let results = linter.lint(code);
1616
assert(results.length > 0);
1717
assert.equal(results[0], "Unexpected console statement.");

Diff for: src/ESLint/MyLinter.js

+4-4
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ export default class MyLinter {
1414
}
1515

1616
loadRule(rule) {
17-
var ruleExports = rule(this._ruleContext);
17+
let ruleExports = rule(this._ruleContext);
1818
// on(nodeType, nodeTypeCallback);
1919
Object.keys(ruleExports).forEach(nodeType => {
2020
this._emitter.on(nodeType, ruleExports[nodeType]);
@@ -23,12 +23,12 @@ export default class MyLinter {
2323

2424

2525
lint(code) {
26-
var messages = [];
27-
var addMessage = (message)=> {
26+
let messages = [];
27+
let addMessage = (message)=> {
2828
messages.push(message);
2929
};
3030
this._ruleContext.on("report", addMessage);
31-
var ast = parse(code);
31+
let ast = parse(code);
3232
traverse(ast, {
3333
enter: (node) => {
3434
this._emitter.emit(node.type, node);

Diff for: src/connect/connect-echo-example.js

+4-4
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ import connect from "connect";
33
import http from "http";
44
import fetch from "node-fetch";
55
import assert from "assert";
6-
var app = connect();
6+
let app = connect();
77
// add Error handling
88
app.use(function (err, req, res, next) {
99
console.error(err.stack);
@@ -15,12 +15,12 @@ app.use(function (req, res) {
1515
req.pipe(res);
1616
});
1717
//create node.js http server and listen on port
18-
var server = http.createServer(app).listen(3000, request);
18+
let server = http.createServer(app).listen(3000, request);
1919

2020
// request => response
2121
function request() {
22-
var closeServer = server.close.bind(server);
23-
var requestBody = {
22+
let closeServer = server.close.bind(server);
23+
let requestBody = {
2424
"key": "value"
2525
};
2626
fetch("http://localhost:3000", {

Diff for: src/connect/connect-example.js

+3-3
Original file line numberDiff line numberDiff line change
@@ -7,18 +7,18 @@ import connect from "connect";
77
import http from "http";
88
import fetch from "node-fetch";
99
const responseText = "response text";
10-
var app = connect();
10+
let app = connect();
1111
// add Error handling
1212
app.use(errorHandler());
1313
// add "X-Content-Type-Options" to response
1414
app.use(nosniff());
1515
// respond to all requests
1616
app.use(hello(responseText));
1717
//create node.js http server and listen on port
18-
var server = http.createServer(app).listen(3000, request);
18+
let server = http.createServer(app).listen(3000, request);
1919

2020
function request() {
21-
var closeServer = server.close.bind(server);
21+
let closeServer = server.close.bind(server);
2222
fetch("http://localhost:3000")
2323
.then(res => res.text())
2424
.then(text => {

Diff for: src/jQuery/calculator-example.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -3,5 +3,5 @@ import assert from "assert";
33
import calculator from "./calculator";
44
import "./calculator-plugin"; // Extend
55

6-
var resultValue = calculator(0).add(10).multi(10).value;
6+
let resultValue = calculator(0).add(10).multi(10).value;
77
assert.equal(resultValue, 10 * 10);

Diff for: test/ESLint/MyLinter-test.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ describe("MyLint", function () {
77
it("should load and lint", function () {
88
let linter = new MyLinter();
99
linter.loadRule(noConsole);
10-
var results = linter.lint(`console.log("test")`);
10+
let results = linter.lint(`console.log("test")`);
1111
assert(results.length > 0);
1212
assert.equal(results[0], "Unexpected console statement.");
1313
});

Diff for: test/connect/hello-test.js

+7-7
Original file line numberDiff line numberDiff line change
@@ -9,11 +9,11 @@ import echo from "../../src/connect/echo";
99
import http from "http";
1010
import fetch from "node-fetch";
1111
describe("connect", function () {
12-
var responseText = "test";
13-
var server;
12+
let responseText = "test";
13+
let server;
1414
describe("errorHandler", function () {
1515
beforeEach(function (done) {
16-
var app = connect();
16+
let app = connect();
1717
app.use(errorHandler());
1818
app.use((req, res, next) => {
1919
next(new Error("wrong"));
@@ -34,7 +34,7 @@ describe("connect", function () {
3434
});
3535
describe("hello", function () {
3636
beforeEach(function (done) {
37-
var app = connect();
37+
let app = connect();
3838
app.use(errorHandler());
3939
app.use(hello(responseText));
4040
server = http.createServer(app).listen(3000, done);
@@ -52,7 +52,7 @@ describe("connect", function () {
5252
});
5353
describe("sniff", function () {
5454
beforeEach(function (done) {
55-
var app = connect();
55+
let app = connect();
5656
app.use(nosniff());
5757
app.use(hello(responseText));
5858
server = http.createServer(app).listen(3000, done);
@@ -69,15 +69,15 @@ describe("connect", function () {
6969
});
7070
describe("echo", function () {
7171
beforeEach(function (done) {
72-
var app = connect();
72+
let app = connect();
7373
app.use(echo());
7474
server = http.createServer(app).listen(3000, done);
7575
});
7676
afterEach(function () {
7777
server && server.close();
7878
});
7979
it("should return request as response", function () {
80-
var requestBody = {
80+
let requestBody = {
8181
key: "value"
8282
};
8383
return fetch("http://localhost:3000", {

Diff for: test/jQuery/greenify-test.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ const testbed = fs.readFileSync(__dirname + "/fixtures/testbed.html", "utf-8");
77
const jquery = fs.readFileSync(__dirname + "/../../node_modules/jquery/dist/jquery.js", "utf-8");
88
const greenify = fs.readFileSync(__dirname + "/../../src/jQuery/greenify.js", "utf-8");
99
describe("greenify", function () {
10-
var $, document;
10+
let $, document;
1111
before(done => {
1212
jsdom.env({
1313
html: testbed,

0 commit comments

Comments
 (0)