[chore]: Update/remove dstack-proxy TODOs (dstackai#2239)

Author: jvstme

docs/docs/reference/environment-variables.md

@@ -103,7 +103,7 @@ For more details on the options below, refer to the [server deployment](../guide
 - `DSTACK_DATABASE_URL`{ #DSTACK_DATABASE_URL } – The database URL to use instead of default SQLite. Currently `dstack` supports Postgres. Example: `postgresql+asyncpg://myuser:mypassword@localhost:5432/mydatabase`. Defaults to `None`.
 - `DSTACK_SERVER_CLOUDWATCH_LOG_GROUP`{ #DSTACK_SERVER_CLOUDWATCH_LOG_GROUP } – The CloudWatch Logs group for workloads logs. If not set, the default file-based log storage is used.
 - `DSTACK_SERVER_CLOUDWATCH_LOG_REGION`{ #DSTACK_SERVER_CLOUDWATCH_LOG_REGION } – The CloudWatch Logs region. Defaults to `None`.
-- `DSTACK_DEFAULT_SERVICE_CLIENT_MAX_BODY_SIZE`{ #DSTACK_DEFAULT_SERVICE_CLIENT_MAX_BODY_SIZE } – Request body size limit for services, in bytes. Defaults to 64 MiB.
+- `DSTACK_DEFAULT_SERVICE_CLIENT_MAX_BODY_SIZE`{ #DSTACK_DEFAULT_SERVICE_CLIENT_MAX_BODY_SIZE } – Request body size limit for services running with a gateway, in bytes. Defaults to 64 MiB.
 - `DSTACK_FORBID_SERVICES_WITHOUT_GATEWAY`{ #DSTACK_FORBID_SERVICES_WITHOUT_GATEWAY } – Forbids registering new services without a gateway if set to any value.
 
 ??? info "Internal environment variables"

src/dstack/_internal/proxy/lib/models.py

@@ -31,7 +31,7 @@ class Service(ImmutableModel):
     domain: Optional[str]  # only used on gateways
     https: Optional[bool]  # only used on gateways
     auth: bool
-    client_max_body_size: int
+    client_max_body_size: int  # only enforced on gateways
     replicas: tuple[Replica, ...]
 
     @property

src/dstack/_internal/proxy/lib/services/service_connection.py

@@ -87,7 +87,7 @@ async def client(self) -> ServiceClient:
 
 class ServiceConnectionPool:
     def __init__(self) -> None:
-        # TODO(#1595): remove connections to stopped replicas in-server
+        # TODO(#2238): remove connections to stopped replicas in-server
         self.connections: Dict[str, ServiceConnection] = {}
 
     async def get(self, replica_id: str) -> Optional[ServiceConnection]:
@@ -139,7 +139,6 @@ async def get_service_replica_client(
             timeout=HTTP_TIMEOUT,
         )
     # Nginx not available, forward directly to the tunnel
-    # TODO(#1595): consider trying different replicas, e.g. using HTTPMultiClient
     replica = random.choice(service.replicas)
     connection = await service_conn_pool.get(replica.id)
     if connection is None:

src/dstack/_internal/server/services/proxy/routers/service_proxy.py

@@ -40,6 +40,3 @@ async def service_reverse_proxy(
     return await service_proxy.proxy(
         project_name, run_name, path, request, auth, repo, service_conn_pool
     )
-
-
-# TODO(#1595): support websockets

src/dstack/_internal/server/services/proxy/services/service_proxy.py

@@ -26,8 +26,6 @@ async def proxy(
     repo: BaseProxyRepo,
     service_conn_pool: ServiceConnectionPool,
 ) -> fastapi.responses.Response:
-    # TODO(#1595): enforce client_max_body_size
-
     if "Upgrade" in request.headers:
         raise ProxyError("Upgrading connections is not supported", status.HTTP_400_BAD_REQUEST)
 
@@ -95,7 +93,7 @@ async def build_upstream_request(
     ).get_stream()
     client.cookies.clear()  # the client is shared by all users, don't leak cookies
 
-    # TODO(#1595): add common proxy headers
+    # TODO(#2237): add common proxy headers
     return client.build_request(
         downstream_request.method, url, headers=downstream_request.headers, content=request_stream
     )