You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Returning Endpoint instances rather than storing these as properties introduces unnecessary complexity to the Rider and Race sections. It would be better to return the relevant result directly, or return the raw response if it is not being parsed.
For example,Race(XX).victory_table().table should become Race(XX).victory_table.
Such calls should automatically update properties common to all endpoints of that instance, such as Race(XX).header_details. To avoid losing data, all raw responses should be accessible somehow.
Where we accept parameters for the methods, we can separate these into separate attributes or use dictionary syntax instead. For example, Rider(XX).year_results(2020).results_df should become Rider(XX).year_results[2020].
The text was updated successfully, but these errors were encountered:
Returning
Endpoint
instances rather than storing these as properties introduces unnecessary complexity to theRider
andRace
sections. It would be better to return the relevant result directly, or return the raw response if it is not being parsed.For example,
Race(XX).victory_table().table
should becomeRace(XX).victory_table
.Such calls should automatically update properties common to all endpoints of that instance, such as
Race(XX).header_details
. To avoid losing data, all raw responses should be accessible somehow.Where we accept parameters for the methods, we can separate these into separate attributes or use dictionary syntax instead. For example,
Rider(XX).year_results(2020).results_df
should becomeRider(XX).year_results[2020]
.The text was updated successfully, but these errors were encountered: