Skip to content

Commit c853381

Browse files
jbedardjbedard
authored
chore(6.0): remove all unsupported rules and packages (#3655)
* chore(6.0): remove all unsupported rules and packages * fixup! chore(6.0): remove all unsupported rules and packages
1 parent f1d6fda commit c853381

File tree

768 files changed

+505
-389456
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

768 files changed

+505
-389456
lines changed

‎.bazelci/presubmit.yml

+20-228
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
---
2-
bazel: 5.0.0
2+
bazel: 6.1.1
33
# Note, this will tell the user to do the wrong thing (manually run buildifer)
44
# See https://github.com/bazelbuild/continuous-integration/issues/1161
55
buildifier:
@@ -13,268 +13,60 @@ tasks:
1313
ubuntu1804:
1414
name: ubuntu1804
1515
platform: ubuntu1804
16-
run_targets:
17-
- "@yarn//:yarn"
18-
- "//internal/node/test:no_deps"
19-
- "//internal/node/test:has_deps_legacy"
20-
- "//internal/node/test:has_deps"
21-
- "//internal/node/test:has_deps_hybrid"
22-
- "//internal/npm_install/test:index"
23-
# Disabled due to https://github.com/bazelbuild/rules_nodejs/issues/1486
24-
#- "@fine_grained_deps_yarn//typescript/bin:tsc"
2516
build_targets:
2617
- "//..."
27-
test_flags:
28-
# Both chrome & firefox are missing shared libs on bazelci ubuntu.
29-
# On circleci we have the same issue but we can work around it using apt-get.
30-
# on bazelci apt-get fails with permission denied and there is no sudo
31-
# command to switch to root.
32-
# TODO(gregmagolan): figure out how to install missing shared libs
33-
- "--test_tag_filters=-e2e,-examples,-browser:chromium-local,-browser:firefox-local,-browser:custom_chrome"
34-
test_targets:
35-
- "//..."
36-
ubuntu1804_debug:
37-
name: ubuntu1804_debug
38-
platform: ubuntu1804
39-
test_flags:
40-
- "--compilation_mode=dbg"
41-
- "--define=VERBOSE_LOGS=1"
42-
# Both chrome & firefox are missing shared libs on bazelci ubuntu.
43-
# On circleci we have the same issue but we can work around it using apt-get.
44-
# on bazelci apt-get fails with permission denied and there is no sudo
45-
# command to switch to root.
46-
# TODO(gregmagolan): figure out how to install missing shared libs
47-
- "--test_tag_filters=-e2e,-examples,-browser:chromium-local,-browser:firefox-local,-browser:custom_chrome"
4818
test_targets:
4919
- "//..."
50-
ubuntu1804_e2e:
51-
name: ubuntu1804_e2e
20+
ubuntu1804-smoke:
21+
name: ubuntu1804-smoke
5222
platform: ubuntu1804
53-
# We need to reduce the memory & CPU usage of the top-level
54-
# bazel process for bazel-in-bazel tests to not
55-
# deplete the system memory completely.
56-
# - startup JVM memory reduced
57-
# - top-level bazel process should use as little memory as possible and only 1 core
58-
# - nested bazel process should use a limited number of cores
59-
shell_commands:
60-
- echo 'startup --host_jvm_args=-Xms256m --host_jvm_args=-Xmx1536m' >> .bazelrc
23+
working_directory: "e2e/smoke"
6124
build_targets:
6225
- "//..."
63-
# We control Bazel version in integration tests, so we don't need USE_BAZEL_VERSION for tests.
64-
skip_use_bazel_version_for_test: true
65-
test_flags:
66-
- "--test_tag_filters=e2e"
67-
- "--local_ram_resources=792"
68-
# test_args will be passed to the nested bazel process
69-
- "--test_arg=--local_ram_resources=13288"
70-
- "--test_arg=--local_cpu_resources=7"
7126
test_targets:
7227
- "//..."
73-
ubuntu1804_examples:
74-
name: ubuntu1804_examples
28+
ubuntu1804-nodejs_host:
29+
name: ubuntu1804-nodejs_host
7530
platform: ubuntu1804
76-
# We need to reduce the memory & CPU usage of the top-level
77-
# bazel process for bazel-in-bazel tests to not
78-
# deplete the system memory completely.
79-
# - startup JVM memory reduced
80-
# - top-level bazel process should use as little memory as possible and only 1 core
81-
# - nested bazel process should use a limited number of cores
82-
shell_commands:
83-
- echo 'startup --host_jvm_args=-Xms256m --host_jvm_args=-Xmx1536m' >> .bazelrc
84-
build_flags:
85-
- "--build_tag_filters=examples"
31+
working_directory: "e2e/nodejs_host"
8632
build_targets:
8733
- "//..."
88-
# We control Bazel version in integration tests, so we don't need USE_BAZEL_VERSION for tests.
89-
skip_use_bazel_version_for_test: true
90-
test_flags:
91-
- "--test_tag_filters=examples"
92-
- "--local_ram_resources=792"
93-
# test_args will be passed to the nested bazel process
94-
- "--test_arg=--local_ram_resources=13288"
95-
- "--test_arg=--local_cpu_resources=7"
96-
# Both chrome & firefox are missing shared libs on bazelci ubuntu.
97-
# On circleci we have the same issue but we can work around it using apt-get.
98-
# on bazelci apt-get fails with permission denied and there is no sudo
99-
# command to switch to root.
100-
# TODO(gregmagolan): figure out how to install missing shared libs
101-
- "--test_arg=--test_tag_filters=-browser:chromium-local,-browser:firefox-local"
102-
- "--test_output=streamed"
10334
test_targets:
10435
- "//..."
10536
# Temporarily disabled MacOS tests until pre-existing failure can be investigated.
106-
# macos:
37+
# macos-smoke:
10738
# name: macos
10839
# platform: macos
109-
# run_targets:
110-
# - "@yarn//:yarn"
111-
# # Regression test for #1493
112-
# - "//internal/node/test:no_deps"
113-
# - "//internal/node/test:has_deps_legacy"
114-
# - "//internal/node/test:has_deps"
115-
# - "//internal/node/test:has_deps_hybrid"
116-
# - "//internal/npm_install/test:index"
117-
# # Disabled due to https://github.com/bazelbuild/rules_nodejs/issues/1486
118-
# #- "@fine_grained_deps_yarn//typescript/bin:tsc"
40+
# working_directory: "e2e/smoke"
11941
# build_targets:
12042
# - "//..."
121-
# test_flags:
122-
# # Firefox are missing shared libs on bazelci mac
123-
# # TODO(gregmagolan): figure out how to install missing shared libs
124-
# - "--test_tag_filters=-e2e,-examples,-browser:firefox-local"
12543
# test_targets:
12644
# - "//..."
127-
# macos_e2e:
128-
# name: macos_e2e
129-
# platform: macos
130-
# # We need to reduce the memory & CPU usage of the top-level
131-
# # bazel process for bazel-in-bazel tests to not
132-
# # deplete the system memory completely.
133-
# # - startup JVM memory reduced
134-
# # - top-level bazel process should use as little memory as possible and only 1 core
135-
# # - nested bazel process should use a limited number of cores
136-
# shell_commands:
137-
# - echo 'startup --host_jvm_args=-Xms256m --host_jvm_args=-Xmx1536m' >> .bazelrc
138-
# build_flags:
139-
# - "--build_tag_filters=e2e"
140-
# build_targets:
141-
# - "//..."
142-
# # We control Bazel version in integration tests, so we don't need USE_BAZEL_VERSION for tests.
143-
# skip_use_bazel_version_for_test: true
144-
# test_flags:
145-
# - "--test_tag_filters=e2e,-no-bazelci-mac"
146-
# - "--local_ram_resources=792"
147-
# # test_args will be passed to the nested bazel process
148-
# # TODO(gregmagolan): fix frequent flake with multiple cores in nested bazel (osx buildkite & local)
149-
# - "--test_arg=--local_ram_resources=13288"
150-
# # Firefox are missing shared libs on bazelci mac
151-
# # TODO(gregmagolan): figure out how to install missing shared libs
152-
# - "--test_arg=--test_tag_filters=-browser:firefox-local"
153-
# test_targets:
154-
# - "//..."
155-
# macos_examples:
156-
# name: macos_examples
157-
# platform: macos
158-
# # We need to reduce the memory & CPU usage of the top-level
159-
# # bazel process for bazel-in-bazel tests to not
160-
# # deplete the system memory completely.
161-
# # - startup JVM memory reduced
162-
# # - top-level bazel process should use as little memory as possible and only 1 core
163-
# # - nested bazel process should use a limited number of cores
164-
# shell_commands:
165-
# - echo 'startup --host_jvm_args=-Xms256m --host_jvm_args=-Xmx1536m' >> .bazelrc
166-
# build_flags:
167-
# - "--build_tag_filters=examples"
168-
# build_targets:
169-
# - "//..."
170-
# # We control Bazel version in integration tests, so we don't need USE_BAZEL_VERSION for tests.
171-
# skip_use_bazel_version_for_test: true
172-
# test_flags:
173-
# - "--test_tag_filters=examples"
174-
# - "--local_ram_resources=792"
175-
# # test_args will be passed to the nested bazel process
176-
# # TODO(gregmagolan): fix frequent flake with multiple cores in nested bazel (osx buildkite & local)
177-
# - "--test_arg=--local_ram_resources=13288"
178-
# # Firefox are missing shared libs on bazelci mac
179-
# # TODO(gregmagolan): figure out how to install missing shared libs
180-
# - "--test_arg=--test_tag_filters=-no-bazelci-mac,-browser:firefox-local"
181-
# test_targets:
182-
# - "//..."
183-
# TODO(gregmagolan): fix platform configuraiton for this test job for Bazel 2.0
184-
# macos_fake_rbe:
185-
# name: macos_fake_rbe
186-
# platform: macos
187-
# shell_commands:
188-
# # Reproduce https://github.com/bazelbuild/rules_nodejs/issues/1305
189-
# # TODO: switch to use real mac cross-platform RBE on CI when
190-
# # https://github.com/bazelbuild/continuous-integration/pull/749
191-
# # lands on bazelci master.
192-
# - echo 'build --platforms=@rbe_default//config:platform' >> .bazelrc
193-
# run_targets:
194-
# - "//internal/node/test:no_deps"
195-
windows:
196-
name: windows
197-
platform: windows
198-
run_targets:
199-
- "@yarn//:yarn"
200-
- "//internal/node/test:no_deps"
201-
- "//internal/node/test:has_deps_legacy"
202-
- "//internal/node/test:has_deps"
203-
- "//internal/node/test:has_deps_hybrid"
204-
- "//internal/npm_install/test:index"
205-
# Disabled due to https://github.com/bazelbuild/rules_nodejs/issues/1486
206-
#- "@fine_grained_deps_yarn//typescript/bin:tsc"
207-
build_flags:
208-
- "--build_tag_filters=-e2e,-examples,-fix-windows,-no-bazelci-windows,-requires-runfiles"
209-
build_targets:
210-
- "//..."
211-
test_flags:
212-
# Firefox not supported on Windows with rules_webtesting (if run it exit with success)
213-
# See https://github.com/bazelbuild/rules_webtesting/blob/0.3.3/browsers/BUILD.bazel#L66.
214-
- "--test_tag_filters=-e2e,-examples,-fix-windows,-no-bazelci-windows,-requires-runfiles,-browser:firefox-local"
215-
test_targets:
216-
- "//..."
217-
windows_runfiles_enabled:
218-
name: windows_runfiles_enabled
45+
windows-smoke:
46+
name: windows-smoke
21947
platform: windows
220-
test_flags:
221-
- "--test_tag_filters=requires-runfiles,-fix-windows,-no-bazelci-windows"
222-
- "--enable_runfiles"
223-
test_targets:
224-
- "//..."
225-
windows_e2e:
226-
name: windows_e2e
227-
platform: windows
228-
build_flags:
229-
- "--build_tag_filters=e2e,-fix-windows,-no-bazelci-windows,-requires-runfiles"
48+
working_directory: "e2e/smoke"
23049
build_targets:
23150
- "//..."
232-
# We control Bazel version in integration tests, so we don't need USE_BAZEL_VERSION for tests.
233-
skip_use_bazel_version_for_test: true
23451
test_flags:
235-
- "--test_tag_filters=e2e,-fix-windows,-no-bazelci-windows,-requires-runfiles"
236-
- "--local_ram_resources=792"
237-
# test_args will be passed to the nested bazel process
238-
- "--test_arg=--local_ram_resources=13288"
239-
# Firefox not supported on Windows with rules_webtesting (if run it exit with success)
240-
# See https://github.com/bazelbuild/rules_webtesting/blob/0.3.3/browsers/BUILD.bazel#L66.
241-
# Chrome fails to launch on Windows inside bazel-in-bazel with: [17:12:04] E/launcher -
242-
# spawn D:\...\external\io_bazel_rules_webtesting\third_party\chromedriver\chromedriver.out\chromedriver_win32\chromedriver.exe ENOENT
243-
- "--test_arg=--test_tag_filters=-fix-windows,-no-bazelci-windows,-requires-runfiles,-browser:chromium-local,-browser:firefox-local"
52+
- "--test_tag_filters=-fix-windows,-no-bazelci-windows"
24453
test_targets:
24554
- "//..."
246-
windows_examples:
247-
name: windows_examples
55+
windows-nodejs_host:
56+
name: windows-nodejs_host
24857
platform: windows
249-
build_flags:
250-
- "--build_tag_filters=examples,-fix-windows,-no-bazelci-windows,-requires-runfiles"
58+
working_directory: "e2e/nodejs_host"
25159
build_targets:
25260
- "//..."
253-
# We control Bazel version in integration tests, so we don't need USE_BAZEL_VERSION for tests.
254-
skip_use_bazel_version_for_test: true
25561
test_flags:
256-
- "--test_tag_filters=examples,-fix-windows,-no-bazelci-windows,-requires-runfiles"
257-
- "--local_ram_resources=792"
258-
# test_args will be passed to the nested bazel process
259-
- "--test_arg=--local_ram_resources=13288"
260-
# Firefox not supported on Windows with rules_webtesting (if run it exit with success)
261-
# See https://github.com/bazelbuild/rules_webtesting/blob/0.3.3/browsers/BUILD.bazel#L66.
262-
# Chrome fails to launch on Windows inside bazel-in-bazel with: [17:12:04] E/launcher -
263-
# spawn D:\...\external\io_bazel_rules_webtesting\third_party\chromedriver\chromedriver.out\chromedriver_win32\chromedriver.exe ENOENT
264-
- "--test_arg=--test_tag_filters=-fix-windows,-no-bazelci-windows,-requires-runfiles,-browser:chromium-local,-browser:firefox-local"
62+
- "--test_tag_filters=-fix-windows,-no-bazelci-windows"
26563
test_targets:
26664
- "//..."
267-
rbe_ubuntu1604:
268-
name: rbe_ubuntu1604
65+
rbe_ubuntu1604-smoke:
66+
name: rbe_ubuntu1604-smoke
26967
platform: rbe_ubuntu1604
68+
working_directory: "e2e/smoke"
27069
build_targets:
27170
- "//..."
272-
build_flags:
273-
# TODO(gregmagolan): figure out how to install missing shared libs
274-
# Without this filter the @cypress external repository will be built and that build will fail due to missing shared libs.
275-
- "--build_tag_filters=-examples,-e2e,-no-rbe,-browser:chromium-local,-browser:firefox-local"
276-
test_flags:
277-
# TODO(gregmagolan): figure out how to install missing shared libs
278-
- "--test_tag_filters=-examples,-e2e,-no-rbe,-browser:chromium-local,-browser:firefox-local"
27971
test_targets:
28072
- "//..."

‎.bazelignore

+3-5
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,11 @@
11
# NB: sematics here are not the same as .gitignore
22
# see https://github.com/bazelbuild/bazel/issues/8106
3+
node_modules
34
.git
45
bazel-out
56

6-
# **/symlinked_node_modules_yarn
7-
node_modules
8-
e2e/symlinked_node_modules_yarn/node_modules
9-
e2e/symlinked_node_modules_npm/node_modules
10-
examples/angular/node_modules
7+
# e2e tests are their own workspaces
8+
e2e
119

1210
# **/dist
1311
dist

‎.bazelrc

-17
Original file line numberDiff line numberDiff line change
@@ -1,23 +1,6 @@
11
# Import shared settings first so we can override below
22
import %workspace%/common.bazelrc
33

4-
# Trick bazel into treating BUILD files under examples/* and e2e/* as being regular files
5-
# This lets us glob() up all the files inside the examples to make them inputs to tests
6-
# To update these lines, just run `yarn bazel:update-deleted-packages`
7-
# (Note, we cannot use common --deleted_packages because the bazel version command doesn't support it)
8-
build --deleted_packages=e2e/bazel_run_chdir,e2e/bazel_run_chdir/subfolder,e2e/fine_grained_symlinks,e2e/linker_disabled_regression,e2e/linker_disabled_regression/subdir,e2e/node_loader_preserve_symlinks,e2e/nodejs_host,e2e/nodejs_image,e2e/nodejs_image/foolib,e2e/packages,e2e/symlinked_node_modules_npm,e2e/symlinked_node_modules_yarn,examples/angular,examples/angular/src,examples/angular/src/app,examples/angular/src/app/hello-world,examples/angular/src/app/home,examples/angular/src/app/todos,examples/angular/src/app/todos/reducers,examples/angular/src/assets,examples/angular/src/lib/shorten,examples/angular/src/shared/material,examples/angular/tools,examples/angular_bazel_architect,examples/angular_bazel_architect/projects/frontend-lib,examples/app,examples/app/styles,examples/app/test,examples/closure,examples/create-react-app,examples/from_source,examples/jest,examples/jest/ts,examples/jest/ts/src,examples/jest/ts/test,examples/kotlin,examples/nestjs,examples/nestjs/src,examples/parcel,examples/protobufjs,examples/react_webpack,examples/toolchain,examples/vue,examples/vue/src,examples/vue/src/components/HelloWorld,examples/web_testing,examples/webapp,examples/worker
9-
query --deleted_packages=e2e/bazel_run_chdir,e2e/bazel_run_chdir/subfolder,e2e/fine_grained_symlinks,e2e/linker_disabled_regression,e2e/linker_disabled_regression/subdir,e2e/node_loader_preserve_symlinks,e2e/nodejs_host,e2e/nodejs_image,e2e/nodejs_image/foolib,e2e/packages,e2e/symlinked_node_modules_npm,e2e/symlinked_node_modules_yarn,examples/angular,examples/angular/src,examples/angular/src/app,examples/angular/src/app/hello-world,examples/angular/src/app/home,examples/angular/src/app/todos,examples/angular/src/app/todos/reducers,examples/angular/src/assets,examples/angular/src/lib/shorten,examples/angular/src/shared/material,examples/angular/tools,examples/angular_bazel_architect,examples/angular_bazel_architect/projects/frontend-lib,examples/app,examples/app/styles,examples/app/test,examples/closure,examples/create-react-app,examples/from_source,examples/jest,examples/jest/ts,examples/jest/ts/src,examples/jest/ts/test,examples/kotlin,examples/nestjs,examples/nestjs/src,examples/parcel,examples/protobufjs,examples/react_webpack,examples/toolchain,examples/vue,examples/vue/src,examples/vue/src/components/HelloWorld,examples/web_testing,examples/webapp,examples/worker
10-
11-
# Mock versioning command to test the --stamp behavior
12-
build --workspace_status_command="echo BUILD_SCM_VERSION 1.2.3"
13-
# ... but when releasing, use the real script instead
14-
build:release --stamp --workspace_status_command=./scripts/current_version.sh
15-
16-
# Define environment value used by some tests such as //internal/npm_install/test:bazel_bin_test
17-
build --define=SOME_TEST_ENV=some_value
18-
test --define=SOME_TEST_ENV=some_value
19-
build --action_env=SOME_OTHER_ENV=some_other_value
20-
214
###############################
225
# Remote Build Execution support
236
# Turn on these settings with

‎.github/BUILD.bazel

+6-5
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
1-
load("@build_bazel_rules_nodejs//:index.bzl", "generated_file_test")
21
load("@rules_codeowners//tools:codeowners.bzl", "generate_codeowners")
2+
load("@bazel_skylib//rules:diff_test.bzl", "diff_test")
33

44
generate_codeowners(
55
name = "gen_codeowners",
@@ -11,8 +11,9 @@ generate_codeowners(
1111
],
1212
)
1313

14-
generated_file_test(
15-
name = "codeowners",
16-
src = "CODEOWNERS",
17-
generated = "gen_codeowners",
14+
diff_test(
15+
name = "check_codeowners",
16+
failure_message = "Please run: bazel run //.github:gen_codeowners",
17+
file1 = ":gen_codeowners",
18+
file2 = "CODEOWNERS",
1819
)

‎.github/workflows/ci.yaml

+2-2
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,6 @@ concurrency:
1717

1818
jobs:
1919
test:
20-
uses: bazel-contrib/.github/.github/workflows/bazel.yaml@v1
20+
uses: bazel-contrib/.github/.github/workflows/bazel.yaml@v2
2121
with:
22-
folders: '["e2e/smoke"]'
22+
folders: '[".", "e2e/smoke", "e2e/nodejs_host"]'

0 commit comments

Comments
 (0)