Skip to content

Commit 9532a4a

Browse files
committed
Consolidated some functions in scalacworker.
1 parent a2a4a03 commit 9532a4a

File tree

1 file changed

+10
-18
lines changed

1 file changed

+10
-18
lines changed

src/java/io/bazel/rulesscala/scalac/ScalacWorker.java

Lines changed: 10 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -37,13 +37,14 @@ public static void main(String[] args) throws Exception {
3737
public void work(String[] args) throws Exception {
3838
CompileOptions ops = new CompileOptions(args);
3939

40-
Path outputJar = Paths.get(ops.outputName);
40+
Path outputJarPath = Paths.get(ops.outputName);
4141

42-
Path workdir = ensureEmptyWorkDirectory(outputJar, ops.currentTarget);
43-
ensureEmptySemanticDBDirectory(outputJar, ops.currentTarget);
42+
Path scalacOutPath = clearWorkDirectory(outputJarPath, ops.currentTarget, "_scalac");
43+
clearWorkDirectory(outputJarPath, ops.currentTarget, "_semanticdb");
4444

45-
Path classes = Files.createDirectories(workdir.resolve("classes"));
46-
Path sources = Files.createDirectories(workdir.resolve("sources"));
45+
Files.createDirectories(scalacOutPath);
46+
Path classes = Files.createDirectories(scalacOutPath.resolve("classes"));
47+
Path sources = Files.createDirectories(scalacOutPath.resolve("sources"));
4748

4849
List<File> jarFiles = extractSourceJars(ops, sources);
4950
List<File> scalaJarFiles = filterFilesByExtension(jarFiles, ".scala");
@@ -83,29 +84,20 @@ public void work(String[] args) throws Exception {
8384

8485
/** Now build the output jar */
8586
String[] jarCreatorArgs = {
86-
"-m", ops.manifestPath, "-t", ops.stampLabel, outputJar.toString(), classes.toString()
87+
"-m", ops.manifestPath, "-t", ops.stampLabel, outputJarPath.toString(), classes.toString()
8788
};
8889
JarCreator.main(jarCreatorArgs);
8990
}
9091

91-
private static Path ensureEmptyWorkDirectory(Path output, String label) throws IOException {
92+
private static Path clearWorkDirectory(Path output, String label, String folderName) throws IOException {
9293
String base = label.substring(label.lastIndexOf(':') + 1);
93-
Path dir = output.resolveSibling("_scalac").resolve(base);
94+
Path dir = output.resolveSibling(folderName).resolve(base);
9495

9596
if (Files.exists(dir)) {
9697
deleteRecursively(dir);
9798
}
9899

99-
return Files.createDirectories(dir);
100-
}
101-
102-
private static void ensureEmptySemanticDBDirectory(Path output, String label) throws IOException {
103-
String base = label.substring(label.lastIndexOf(':') + 1);
104-
Path dir = output.resolveSibling("_semanticdb").resolve(base);
105-
106-
if (Files.exists(dir)) {
107-
deleteRecursively(dir);
108-
}
100+
return dir;
109101
}
110102

111103
private static String[] collectSrcJarSources(

0 commit comments

Comments
 (0)