Skip to content

Commit 978c1a9

Browse files
committed
#231: Picked only the changes regarding attachment extensions from develop
1 parent 3603f56 commit 978c1a9

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

src/main/java/org/simplejavamail/converter/internal/mimemessage/MimeMessageHelper.java

+5-5
Original file line numberDiff line numberDiff line change
@@ -286,16 +286,16 @@ static String determineResourceName(final AttachmentResource attachmentResource,
286286
resourceName = "resource" + UUID.randomUUID();
287287
}
288288
if (includeExtension && !valueNullOrEmpty(datasourceName)) {
289-
@SuppressWarnings("UnnecessaryLocalVariable") final
290-
String possibleFilename = datasourceName;
291-
if (possibleFilename.contains(".")) {
292-
final String extension = possibleFilename.substring(possibleFilename.lastIndexOf("."), possibleFilename.length());
289+
@SuppressWarnings("UnnecessaryLocalVariable")
290+
final String possibleFilename = datasourceName;
291+
if (!resourceName.contains(".") && possibleFilename.contains(".")) {
292+
final String extension = possibleFilename.substring(possibleFilename.lastIndexOf("."));
293293
if (!resourceName.endsWith(extension)) {
294294
resourceName += extension;
295295
}
296296
}
297297
} else if (!includeExtension && resourceName.contains(".") && resourceName.equals(datasourceName)) {
298-
final String extension = resourceName.substring(resourceName.lastIndexOf("."), resourceName.length());
298+
final String extension = resourceName.substring(resourceName.lastIndexOf("."));
299299
resourceName = resourceName.replace(extension, "");
300300
}
301301
return resourceName;

0 commit comments

Comments
 (0)