#198: Mark failed Transport objects as faulty

Author: bbottema

modules/batch-module/src/main/java/org/simplejavamail/internal/batchsupport/BatchSupport.java

@@ -73,7 +73,7 @@ public ExecutorService createDefaultExecutorService(final int threadPoolSize, fi
 	public LifecycleDelegatingTransport acquireTransport(@Nonnull final Session session) {
 		try {
 			SimpleDelegatingPoolable<Transport> poolableTransport = smtpConnectionPool.claimResourceFromPool(new ResourcePoolKey<>(session));
-			return new LifecycleDelegatingTransportImpl(smtpConnectionPool, poolableTransport);
+			return new LifecycleDelegatingTransportImpl(poolableTransport);
 		} catch (InterruptedException e) {
 			throw new BatchException(format(ERROR_ACQUIRING_KEYED_POOLABLE, session), e);
 		}

modules/batch-module/src/main/java/org/simplejavamail/internal/batchsupport/LifecycleDelegatingTransportImpl.java

@@ -2,28 +2,25 @@
 
 import org.bbottema.clusterstormpot.util.SimpleDelegatingPoolable;
 import org.simplejavamail.api.internal.batchsupport.LifecycleDelegatingTransport;
-import org.simplejavamail.smtpconnectionpool.SmtpConnectionPool;
 
 import javax.annotation.Nonnull;
 import javax.mail.Transport;
 
 /**
  * Wraps {@link SimpleDelegatingPoolable} to implement {@link LifecycleDelegatingTransport}, so transport resources
- * can be used outside the batchmodule and released to be reused.
+ * can be used outside the batchmodule and released to be reused in connection pool.
  */
 class LifecycleDelegatingTransportImpl implements LifecycleDelegatingTransport {
 	private final SimpleDelegatingPoolable<Transport> pooledTransport;
-	private final SmtpConnectionPool smtpConnectionPool;
 
-	LifecycleDelegatingTransportImpl(final SmtpConnectionPool smtpConnectionPool, final SimpleDelegatingPoolable<Transport> pooledTransport) {
-		this.smtpConnectionPool = smtpConnectionPool;
+	LifecycleDelegatingTransportImpl(final SimpleDelegatingPoolable<Transport> pooledTransport) {
 		this.pooledTransport = pooledTransport;
 	}
 
 	@Nonnull
 	@Override
 	public Transport getTransport() {
-		return pooledTransport.getDelegate();
+		return pooledTransport.getAllocatedDelegate();
 	}
 
 	@Override
@@ -33,8 +30,6 @@ public void signalTransportUsed() {
 
 	@Override
 	public void signalTransportFailed() {
-		// FIXME handle failed Transport intance
-		//smtpConnectionPool.
-		//pooledTransport.
+		pooledTransport.releaseFaulty();
 	}
 }