Fix for issue #534: Gender-digit is incorrect for Swedish Personnummer generation (#535)

* Corrected gender handling in Swedish Personnummer

Second last digit should be even for Female
Second last digit should be odd for Male

* Reverted change in comment

Author: LarsBergqvist

Source/Bogus.Tests/ExtensionTests/SwedishExtensionTest.cs

@@ -60,7 +60,7 @@ public void samordningsnummer_should_contain_offset_date_of_birth()
    [Theory]
    [InlineData(false)]
    [InlineData(true)]
-   public void when_person_is_male_second_last_number_is_even(bool isSamordningsnummer)
+   public void when_person_is_male_second_last_number_is_odd(bool isSamordningsnummer)
    {
       var f = new Faker("sv");
       var person = f.Person;
@@ -71,15 +71,15 @@ public void when_person_is_male_second_last_number_is_even(bool isSamordningsnum
       var secondLast = int.Parse(identificationNumber.Substring(identificationNumber.Length - 2, 1));
 
       secondLast.Should()
-         .Match(x => x % 2 == 0)
+         .Match(x => x % 2 == 1)
          .And.BeLessThan(10)
          .And.BeGreaterThan(0);
    }
 
    [Theory]
    [InlineData(false)]
    [InlineData(true)]
-   public void when_person_is_female_second_last_number_is_odd(bool isSamordningsnummer)
+   public void when_person_is_female_second_last_number_is_even(bool isSamordningsnummer)
    {
       var f = new Faker("sv");
       var person = f.Person;
@@ -90,7 +90,7 @@ public void when_person_is_female_second_last_number_is_odd(bool isSamordningsnu
       var secondLast = int.Parse(identificationNumber.Substring(identificationNumber.Length - 2, 1));
 
       secondLast.Should()
-         .Match(x => x % 2 == 1)
+         .Match(x => x % 2 == 0)
          .And.BeLessThan(10)
          .And.BeGreaterThan(0);
    }

Source/Bogus/Extensions/Sweden/ExtensionsForSweden.cs

@@ -48,7 +48,7 @@ public static string Personnummer(this Person person)
    /// </summary>
    /// <remarks>
    /// Coordination numbers enable Swedish public authorities and other organizations with a public function 
-   /// to identify people who are not currently – and have never been – registered at an address in Sweden.
+   /// to identify people who are not currently – and have never been – registered at an address in Sweden.
    /// </remarks>
    public static string Samordningsnummer(this Person person)
    {
@@ -90,9 +90,9 @@ private static string GenerateIndividualNumber(Randomizer r, Gender gender, Date
    private static int GetGenderNumber(Randomizer r, Gender gender)
    {
       if( gender is Gender.Male )
-         return r.Even(1, 9);
-      if( gender is Gender.Female )
          return r.Odd(1, 9);
+      if( gender is Gender.Female )
+         return r.Even(1, 9);
       throw new ArgumentOutOfRangeException(nameof(gender), gender, "Gender not handled.");
    }