Skip to content

Commit 42f31aa

Browse files
committed
Flip setup_hooks around
1 parent 18407cc commit 42f31aa

File tree

2 files changed

+23
-22
lines changed

2 files changed

+23
-22
lines changed

lib/ui/experiments/setup_hooks.dart

Lines changed: 23 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,23 @@
44

55
part of dart.ui;
66

7+
Future<developer.ServiceExtensionResponse> _reinitializeScene(
8+
String method,
9+
Map<String, String> parameters,
10+
) async {
11+
final String? assetKey = parameters['assetKey'];
12+
if (assetKey != null) {
13+
await SceneNode._reinitializeScene(assetKey);
14+
}
15+
16+
// Always succeed.
17+
return developer.ServiceExtensionResponse.result(json.encode(<String, String>{
18+
'type': 'Success',
19+
}));
20+
}
21+
22+
// This is a copy of ui/setup_hooks.dart, but with reinitializeScene added for hot reloading 3D scenes.
23+
724
@pragma('vm:entry-point')
825
void _setupHooks() {
926
assert(() {
@@ -15,6 +32,12 @@ void _setupHooks() {
1532
'ext.ui.window.reinitializeShader',
1633
_reinitializeShader,
1734
);
35+
36+
// In debug mode, allow 3D scenes to be reinitialized.
37+
developer.registerExtension(
38+
'ext.ui.window.reinitializeScene',
39+
_reinitializeScene,
40+
);
1841
return true;
1942
}());
2043

lib/ui/setup_hooks.dart

Lines changed: 0 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -4,23 +4,6 @@
44

55
part of dart.ui;
66

7-
Future<developer.ServiceExtensionResponse> _reinitializeScene(
8-
String method,
9-
Map<String, String> parameters,
10-
) async {
11-
final String? assetKey = parameters['assetKey'];
12-
if (assetKey != null) {
13-
await SceneNode._reinitializeScene(assetKey);
14-
}
15-
16-
// Always succeed.
17-
return developer.ServiceExtensionResponse.result(json.encode(<String, String>{
18-
'type': 'Success',
19-
}));
20-
}
21-
22-
// This is a copy of ui/setup_hooks.dart, but with reinitializeScene added for hot reloading 3D scenes.
23-
247
@pragma('vm:entry-point')
258
void _setupHooks() {
269
assert(() {
@@ -33,11 +16,6 @@ void _setupHooks() {
3316
_reinitializeShader,
3417
);
3518

36-
// In debug mode, allow 3D scenes to be reinitialized.
37-
developer.registerExtension(
38-
'ext.ui.window.reinitializeScene',
39-
_reinitializeScene,
40-
);
4119
return true;
4220
}());
4321

0 commit comments

Comments
 (0)