Skip to content

Commit 5b8ff31

Browse files
sha1nbstrausser
authored and
bstrausser
committed
fix: unclosed socket warning in db containers (testcontainers#378)
This PR fixes testcontainers#379
1 parent 8c95554 commit 5b8ff31

File tree

1 file changed

+4
-1
lines changed

1 file changed

+4
-1
lines changed

core/testcontainers/core/generic.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,10 @@ def _connect(self) -> None:
3636
import sqlalchemy
3737

3838
engine = sqlalchemy.create_engine(self.get_connection_url())
39-
engine.connect()
39+
try:
40+
engine.connect()
41+
finally:
42+
engine.dispose()
4043

4144
def get_connection_url(self) -> str:
4245
raise NotImplementedError

0 commit comments

Comments
 (0)