Skip to content

Commit a755ed9

Browse files
feat: Don't generate extra models for allOf of one model BNCH-20256 (#44)
1 parent 8cba8e9 commit a755ed9

File tree

13 files changed

+42
-762
lines changed

13 files changed

+42
-762
lines changed

Diff for: end_to_end_tests/golden-record-custom/custom_e2e/models/__init__.py

-4
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,6 @@
11
""" Contains all the data models used in inputs/outputs """
22

33
from .a_model import AModel
4-
from .a_model_model import AModelModel
5-
from .a_model_not_required_model import AModelNotRequiredModel
6-
from .a_model_not_required_nullable_model import AModelNotRequiredNullableModel
7-
from .a_model_nullable_model import AModelNullableModel
84
from .an_enum import AnEnum
95
from .an_int_enum import AnIntEnum
106
from .body_upload_file_tests_upload_post import BodyUploadFileTestsUploadPost

Diff for: end_to_end_tests/golden-record-custom/custom_e2e/models/a_model.py

+9-13
Original file line numberDiff line numberDiff line change
@@ -4,10 +4,6 @@
44
import attr
55
from dateutil.parser import isoparse
66

7-
from ..models.a_model_model import AModelModel
8-
from ..models.a_model_not_required_model import AModelNotRequiredModel
9-
from ..models.a_model_not_required_nullable_model import AModelNotRequiredNullableModel
10-
from ..models.a_model_nullable_model import AModelNullableModel
117
from ..models.an_enum import AnEnum
128
from ..models.different_enum import DifferentEnum
139
from ..models.free_form_model import FreeFormModel
@@ -23,18 +19,18 @@ class AModel:
2319
a_camel_date_time: Union[datetime.datetime, datetime.date]
2420
a_date: datetime.date
2521
required_not_nullable: str
26-
model: AModelModel
22+
model: ModelWithUnionProperty
2723
one_of_models: Union[FreeFormModel, ModelWithUnionProperty]
2824
a_nullable_date: Optional[datetime.date]
2925
required_nullable: Optional[str]
30-
nullable_model: Optional[AModelNullableModel]
26+
nullable_model: Optional[ModelWithUnionProperty]
3127
nullable_one_of_models: Union[None, FreeFormModel, ModelWithUnionProperty]
3228
nested_list_of_enums: Union[Unset, List[List[DifferentEnum]]] = UNSET
3329
attr_1_leading_digit: Union[Unset, str] = UNSET
3430
not_required_nullable: Union[Unset, None, str] = UNSET
3531
not_required_not_nullable: Union[Unset, str] = UNSET
36-
not_required_model: Union[Unset, AModelNotRequiredModel] = UNSET
37-
not_required_nullable_model: Union[Unset, None, AModelNotRequiredNullableModel] = UNSET
32+
not_required_model: Union[Unset, ModelWithUnionProperty] = UNSET
33+
not_required_nullable_model: Union[Unset, None, ModelWithUnionProperty] = UNSET
3834
not_required_one_of_models: Union[Unset, FreeFormModel, ModelWithUnionProperty] = UNSET
3935
not_required_nullable_one_of_models: Union[Unset, None, FreeFormModel, ModelWithUnionProperty, str] = UNSET
4036

@@ -189,7 +185,7 @@ def _parse_a_camel_date_time(data: Union[str]) -> Union[datetime.datetime, datet
189185

190186
required_not_nullable = d.pop("required_not_nullable")
191187

192-
model = AModelModel.from_dict(d.pop("model"))
188+
model = ModelWithUnionProperty.from_dict(d.pop("model"))
193189

194190
def _parse_one_of_models(data: Union[Dict[str, Any]]) -> Union[FreeFormModel, ModelWithUnionProperty]:
195191
one_of_models: Union[FreeFormModel, ModelWithUnionProperty]
@@ -237,17 +233,17 @@ def _parse_one_of_models(data: Union[Dict[str, Any]]) -> Union[FreeFormModel, Mo
237233
nullable_model = None
238234
_nullable_model = d.pop("nullable_model")
239235
if _nullable_model is not None:
240-
nullable_model = AModelNullableModel.from_dict(_nullable_model)
236+
nullable_model = ModelWithUnionProperty.from_dict(_nullable_model)
241237

242-
not_required_model: Union[Unset, AModelNotRequiredModel] = UNSET
238+
not_required_model: Union[Unset, ModelWithUnionProperty] = UNSET
243239
_not_required_model = d.pop("not_required_model", UNSET)
244240
if not isinstance(_not_required_model, Unset):
245-
not_required_model = AModelNotRequiredModel.from_dict(_not_required_model)
241+
not_required_model = ModelWithUnionProperty.from_dict(_not_required_model)
246242

247243
not_required_nullable_model = None
248244
_not_required_nullable_model = d.pop("not_required_nullable_model", UNSET)
249245
if _not_required_nullable_model is not None and not isinstance(_not_required_nullable_model, Unset):
250-
not_required_nullable_model = AModelNotRequiredNullableModel.from_dict(_not_required_nullable_model)
246+
not_required_nullable_model = ModelWithUnionProperty.from_dict(_not_required_nullable_model)
251247

252248
def _parse_nullable_one_of_models(
253249
data: Union[None, Dict[str, Any]]

Diff for: end_to_end_tests/golden-record-custom/custom_e2e/models/a_model_model.py

-90
This file was deleted.

Diff for: end_to_end_tests/golden-record-custom/custom_e2e/models/a_model_not_required_model.py

-90
This file was deleted.

Diff for: end_to_end_tests/golden-record-custom/custom_e2e/models/a_model_not_required_nullable_model.py

-90
This file was deleted.

0 commit comments

Comments
 (0)