chore(tests): Refactoring arrow visibility tests

Author: benjaminch

src/timepicker/test/timepicker.spec.js

@@ -376,6 +376,11 @@ describe('timepicker directive', function () {
     expect(getModelState()).toEqual([14, 40]);
   });
 
+  it('displays arrows controls by default correctly', function () {
+    $rootScope.$digest();
+    expect(element.find('tr').length).toBe(3);
+  });
+
   describe('attributes', function () {
     beforeEach(function() {
       $rootScope.hstep = 2;
@@ -874,73 +879,32 @@ describe('timepicker directive', function () {
     });
   });
 
-  describe('setting timepickerConfig arrow controls default visibility', function () {
-
-    beforeEach(inject(function(_$compile_, _$rootScope_, timepickerConfig) {
-      element = $compile('<timepicker ng-model="time" ng-required="true"></timepicker>')($rootScope);
-      $rootScope.$digest();
-    }));
-
-    function countElementsTr(isUp) {
-      return element.find('tr').length;
-    }
-
-    it('displays arrows controls by default correctly', function () {
-      $rootScope.$digest();
-
-      var upElementsCount = countElementsTr(true);
-      var downElementsCount = countElementsTr(false);
-
-      expect(upElementsCount).toBe(3);
-      expect(downElementsCount).toBe(3);
-    });
-
-  });
-
   describe('setting timepickerConfig arrow controls check initial show', function () {
 
-    beforeEach(inject(function(_$compile_, _$rootScope_, timepickerConfig) {
+    beforeEach(inject(function(_$compile_, _$rootScope_) {
       $rootScope.showArrowsControls = true;
       element = $compile('<timepicker ng-model="time" ng-required="true" show-arrows-controls="showArrowsControls"></timepicker>')($rootScope);
       $rootScope.$digest();
     }));
 
-    function countElementsTr(isUp) {
-      return element.find('tr').length;
-    }
-
     it('displays arrows controls correctly', function () {
       $rootScope.$digest();
-
-      var upElementsCount = countElementsTr(true);
-      var downElementsCount = countElementsTr(false);
-
-      expect(upElementsCount).toBe(3);
-      expect(downElementsCount).toBe(3);
+      expect(element.find('tr').length).toBe(3);
     });
 
   });
 
   describe('setting timepickerConfig arrow controls check initial hide', function () {
 
-    beforeEach(inject(function(_$compile_, _$rootScope_, timepickerConfig) {
+    beforeEach(inject(function(_$compile_, _$rootScope_) {
       $rootScope.showArrowsControls = false;
       element = $compile('<timepicker ng-model="time" ng-required="true" show-arrows-controls="showArrowsControls"></timepicker>')($rootScope);
       $rootScope.$digest();
     }));
 
-    function countElementsTr(isUp) {
-      return element.find('tr').length;
-    }
-
     it('hides arrows controls correctly', function () {
       $rootScope.$digest();
-
-      var upElementsCount = countElementsTr(true);
-      var downElementsCount = countElementsTr(false);
-
-      expect(upElementsCount).toBe(1);
-      expect(downElementsCount).toBe(1);
+      expect(element.find('tr').length).toBe(1);
     });
 
   });