lints

Author: UkoeHB

Diff for: crates/bevy_render/src/view/visibility/mod.rs

@@ -215,46 +215,48 @@ impl Plugin for VisibilityPlugin {
     fn build(&self, app: &mut bevy_app::App) {
         use VisibilitySystems::*;
 
-        app.configure_sets(
-            PostUpdate,
-            PropagateRenderGroupsSet.in_set(VisibilityPropagate),
-        )
-        .add_systems(
-            PostUpdate,
-            (
-                calculate_bounds.in_set(CalculateBounds),
-                update_frusta::<OrthographicProjection>
-                    .in_set(UpdateOrthographicFrusta)
-                    .after(camera_system::<OrthographicProjection>)
-                    .after(TransformSystem::TransformPropagate)
-                    // We assume that no camera will have more than one projection component,
-                    // so these systems will run independently of one another.
-                    // FIXME: Add an archetype invariant for this https://github.com/bevyengine/bevy/issues/1481.
-                    .ambiguous_with(update_frusta::<PerspectiveProjection>)
-                    .ambiguous_with(update_frusta::<Projection>),
-                update_frusta::<PerspectiveProjection>
-                    .in_set(UpdatePerspectiveFrusta)
-                    .after(camera_system::<PerspectiveProjection>)
-                    .after(TransformSystem::TransformPropagate)
-                    // We assume that no camera will have more than one projection component,
-                    // so these systems will run independently of one another.
-                    // FIXME: Add an archetype invariant for this https://github.com/bevyengine/bevy/issues/1481.
-                    .ambiguous_with(update_frusta::<Projection>),
-                update_frusta::<Projection>
-                    .in_set(UpdateProjectionFrusta)
-                    .after(camera_system::<Projection>)
-                    .after(TransformSystem::TransformPropagate),
-                (visibility_propagate_system, reset_view_visibility).in_set(VisibilityPropagate),
-                check_visibility
-                    .in_set(CheckVisibility)
-                    .after(CalculateBounds)
-                    .after(UpdateOrthographicFrusta)
-                    .after(UpdatePerspectiveFrusta)
-                    .after(UpdateProjectionFrusta)
-                    .after(VisibilityPropagate)
-                    .after(TransformSystem::TransformPropagate),
-            ),
-        );
+        app.add_plugins(PropagateRenderGroupsPlugin)
+            .configure_sets(
+                PostUpdate,
+                PropagateRenderGroupsSet.in_set(VisibilityPropagate),
+            )
+            .add_systems(
+                PostUpdate,
+                (
+                    calculate_bounds.in_set(CalculateBounds),
+                    update_frusta::<OrthographicProjection>
+                        .in_set(UpdateOrthographicFrusta)
+                        .after(camera_system::<OrthographicProjection>)
+                        .after(TransformSystem::TransformPropagate)
+                        // We assume that no camera will have more than one projection component,
+                        // so these systems will run independently of one another.
+                        // FIXME: Add an archetype invariant for this https://github.com/bevyengine/bevy/issues/1481.
+                        .ambiguous_with(update_frusta::<PerspectiveProjection>)
+                        .ambiguous_with(update_frusta::<Projection>),
+                    update_frusta::<PerspectiveProjection>
+                        .in_set(UpdatePerspectiveFrusta)
+                        .after(camera_system::<PerspectiveProjection>)
+                        .after(TransformSystem::TransformPropagate)
+                        // We assume that no camera will have more than one projection component,
+                        // so these systems will run independently of one another.
+                        // FIXME: Add an archetype invariant for this https://github.com/bevyengine/bevy/issues/1481.
+                        .ambiguous_with(update_frusta::<Projection>),
+                    update_frusta::<Projection>
+                        .in_set(UpdateProjectionFrusta)
+                        .after(camera_system::<Projection>)
+                        .after(TransformSystem::TransformPropagate),
+                    (visibility_propagate_system, reset_view_visibility)
+                        .in_set(VisibilityPropagate),
+                    check_visibility
+                        .in_set(CheckVisibility)
+                        .after(CalculateBounds)
+                        .after(UpdateOrthographicFrusta)
+                        .after(UpdatePerspectiveFrusta)
+                        .after(UpdateProjectionFrusta)
+                        .after(VisibilityPropagate)
+                        .after(TransformSystem::TransformPropagate),
+                ),
+            );
     }
 }
 

Diff for: crates/bevy_render/src/view/visibility/propagate_render_groups.rs

@@ -136,7 +136,7 @@ The base-line performance cost of this algorithm comes from detecting changes, w
 use crate::view::*;
 
 use crate::prelude::Camera;
-use bevy_app::{App, Plugin, PostUpdate};
+use bevy_app::PostUpdate;
 use bevy_derive::Deref;
 use bevy_ecs::entity::EntityHashSet;
 use bevy_ecs::prelude::*;
@@ -274,15 +274,6 @@ pub struct InheritedRenderGroups {
     pub computed: RenderGroups,
 }
 
-impl InheritedRenderGroups {
-    fn empty() -> Self {
-        Self {
-            propagator: Entity::PLACEHOLDER,
-            computed: RenderGroups::empty(),
-        }
-    }
-}
-
 /// Contains the final [`RenderGroups`] of an entity for extraction to the render world.
 #[derive(Component, Debug, Deref)]
 pub struct ExtractedRenderGroups(RenderGroups);