[BOLT] Fix more review nits (llvm#120064)

Author: bgergely0

bolt/include/bolt/Core/MCPlus.h

@@ -72,13 +72,13 @@ class MCAnnotation {
     kLabel,               /// MCSymbol pointing to this instruction.
     kSize,                /// Size of the instruction.
     kDynamicBranch,       /// Jit instruction patched at runtime.
-    kSigning,             /// Inst is a signing instruction (paciasp, etc.)
-    kSigned,              /// Inst is in a range where RA is signed
-    kAuthenticating,      /// Authenticating inst (e.g. autiasp)
-    kUnsigned,            /// Inst is in a range where RA is unsigned
-    kRememberState,       /// Inst has rememberState CFI
-    kRestoreState,        /// Inst has restoreState CFI
-    kNegateState,         /// Inst has OpNegateRAState CFI
+    kSigning,             /// Inst is a signing instruction (paciasp, etc.).
+    kSigned,              /// Inst is in a range where RA is signed.
+    kAuthenticating,      /// Authenticating inst (e.g. autiasp).
+    kUnsigned,            /// Inst is in a range where RA is unsigned.
+    kRememberState,       /// Inst has rememberState CFI.
+    kRestoreState,        /// Inst has restoreState CFI.
+    kNegateState,         /// Inst has OpNegateRAState CFI.
     kGeneric,             /// First generic annotation.
   };
 

bolt/lib/Core/MCPlusBuilder.cpp

@@ -211,10 +211,8 @@ bool MCPlusBuilder::isRAUnsigned(const MCInst &Inst) const {
 }
 
 bool MCPlusBuilder::isRAStateUnknown(const MCInst &Inst) const {
-  if (isRAUnsigned(Inst) || isRASigned(Inst) || isRASigning(Inst) ||
-      isAuthenticating(Inst))
-    return false;
-  return true;
+  return !(isRAUnsigned(Inst) || isRASigned(Inst) || isRASigning(Inst) ||
+           isAuthenticating(Inst));
 }
 
 std::optional<MCLandingPad> MCPlusBuilder::getEHInfo(const MCInst &Inst) const {

bolt/lib/Passes/MarkRAStates.cpp

@@ -74,7 +74,6 @@ void MarkRAStates::runOnFunction(BinaryFunction &BF) {
       if (BC.MIB->isPSign(Inst)) {
         assert(!RAState && "Signed RA State before PSign");
         BC.MIB->setRASigning(Inst);
-
       } else if (BC.MIB->isPAuth(Inst)) {
         assert(RAState && "Unsigned RA State before PAuth");
         BC.MIB->setAuthenticating(Inst);