fix: ensure ssl verification happens with async client

bhearsum · bhearsum · commit 53d45249c133 · 2025-04-17T12:00:32.000-04:00
gql recently had an issue reported where SSL connections are not verified by default: graphql-python/gql#529 They're planning to make it the default behaviour in their next release, but we should ensure SSL verification happens in the meantime.
diff --git a/pyproject.toml b/pyproject.toml
@@ -8,7 +8,7 @@ readme = "README.md"
 
 [tool.poetry.dependencies]
 python = "^3.8"
-gql = {extras = ["aiohttp", "requests"], version = "^3.4.1"}
+gql = {extras = ["aiohttp", "requests"], version = "^3.5.1"}
 requests = "^2.31.0"
 aiohttp = {extras = ["speedups"], version = "^3.8.6"}
 pyjwt = {extras = ["crypto"], version = "^2.8.0"}
diff --git a/src/simple_github/client.py b/src/simple_github/client.py
@@ -249,7 +249,7 @@ async def _get_gql_session(self) -> ReconnectingAsyncClientSession:
             "Accept": "application/vnd.github+json",
             "Authorization": f"Bearer {token}",
         }
-        transport = AIOHTTPTransport(url=GITHUB_GRAPHQL_ENDPOINT, headers=headers)
+        transport = AIOHTTPTransport(url=GITHUB_GRAPHQL_ENDPOINT, headers=headers, ssl=True)
         self._gql_client = GqlClient(
             transport=transport, fetch_schema_from_transport=False
         )

Original file line number	Diff line number	Diff line change
`@@ -249,7 +249,7 @@ async def _get_gql_session(self) -> ReconnectingAsyncClientSession:`
`249`	`249`	`"Accept": "application/vnd.github+json",`
`250`	`250`	`"Authorization": f"Bearer {token}",`
`251`	`251`	`}`
`252`		`- transport = AIOHTTPTransport(url=GITHUB_GRAPHQL_ENDPOINT, headers=headers)`
	`252`	`+ transport = AIOHTTPTransport(url=GITHUB_GRAPHQL_ENDPOINT, headers=headers, ssl=True)`
`253`	`253`	`self._gql_client = GqlClient(`
`254`	`254`	`transport=transport, fetch_schema_from_transport=False`
`255`	`255`	`)`