moveonly: add mp/type-char.h

Author: ryanofsky

CMakeLists.txt

@@ -45,6 +45,7 @@ set(MP_PUBLIC_HEADERS
   include/mp/proxy-io.h
   include/mp/proxy-types.h
   include/mp/proxy.h
+  include/mp/type-char.h
   include/mp/type-context.h
   include/mp/type-map.h
   include/mp/type-number.h

include/mp/proxy-types.h

@@ -141,19 +141,6 @@ struct ReadDestUpdate
     Value& m_value;
 };
 
-template <size_t size, typename Input, typename ReadDest>
-decltype(auto) CustomReadField(TypeList<unsigned char[size]>,
-    Priority<1>,
-    InvokeContext& invoke_context,
-    Input&& input,
-    ReadDest&& read_dest)
-{
-    return read_dest.update([&](auto& value) {
-        auto data = input.get();
-        memcpy(value, data.begin(), size);
-    });
-}
-
 template <typename Interface, typename Impl>
 std::unique_ptr<Impl> MakeProxyClient(InvokeContext& context, typename Interface::Client&& client)
 {
@@ -306,17 +293,6 @@ void CustomBuildField(TypeList<LocalType>, Priority<1>, InvokeContext& invoke_co
 {
 }
 
-template <typename Output, size_t size>
-void CustomBuildField(TypeList<const unsigned char*>,
-    Priority<3>,
-    InvokeContext& invoke_context,
-    const unsigned char (&value)[size],
-    Output&& output)
-{
-    auto result = output.init(size);
-    memcpy(result.begin(), value, size);
-}
-
 template <typename... Values>
 bool CustomHasValue(InvokeContext& invoke_context, Values&&... value)
 {

include/mp/type-char.h

@@ -0,0 +1,36 @@
+// Copyright (c) 2025 The Bitcoin Core developers
+// Distributed under the MIT software license, see the accompanying
+// file COPYING or http://www.opensource.org/licenses/mit-license.php.
+
+#ifndef MP_PROXY_TYPE_CHAR_H
+#define MP_PROXY_TYPE_CHAR_H
+
+#include <mp/util.h>
+
+namespace mp {
+template <typename Output, size_t size>
+void CustomBuildField(TypeList<const unsigned char*>,
+    Priority<3>,
+    InvokeContext& invoke_context,
+    const unsigned char (&value)[size],
+    Output&& output)
+{
+    auto result = output.init(size);
+    memcpy(result.begin(), value, size);
+}
+
+template <size_t size, typename Input, typename ReadDest>
+decltype(auto) CustomReadField(TypeList<unsigned char[size]>,
+    Priority<1>,
+    InvokeContext& invoke_context,
+    Input&& input,
+    ReadDest&& read_dest)
+{
+    return read_dest.update([&](auto& value) {
+        auto data = input.get();
+        memcpy(value, data.begin(), size);
+    });
+}
+} // namespace mp
+
+#endif // MP_PROXY_TYPE_CHAR_H