simln-lib: use TaskTracker instead of JoinSet in produce_simulation_results

Author: elnosh

simln-lib/src/lib.rs

@@ -21,6 +21,7 @@ use tokio::sync::mpsc::{channel, Receiver, Sender};
 use tokio::sync::Mutex;
 use tokio::task::JoinSet;
 use tokio::{select, time, time::Duration};
+use tokio_util::task::TaskTracker;
 use triggered::{Listener, Trigger};
 
 use self::defined_activity::DefinedPaymentActivity;
@@ -1346,7 +1347,7 @@ async fn produce_simulation_results(
     results: Sender<(Payment, PaymentResult)>,
     listener: Listener,
 ) -> Result<(), SimulationError> {
-    let mut set = tokio::task::JoinSet::new();
+    let set = TaskTracker::new();
 
     let result = loop {
         tokio::select! {
@@ -1390,12 +1391,9 @@ async fn produce_simulation_results(
         }
     };
 
+    set.close();
+    set.wait().await;
     log::debug!("Simulation results producer exiting.");
-    while let Some(res) = set.join_next().await {
-        if let Err(e) = res {
-            log::error!("Simulation results producer task exited with error: {e}.");
-        }
-    }
 
     result
 }