Skip to content

Add CI tests for building individual packages #1944

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
notmandatory opened this issue Jun 26, 2023 · 5 comments · May be fixed by #1575
Open

Add CI tests for building individual packages #1944

notmandatory opened this issue Jun 26, 2023 · 5 comments · May be fixed by #1575
Labels
github_actions Pull requests that update GitHub Actions code

Comments

@notmandatory
Copy link
Member

Describe the enhancement

As described in #1017 it's possible in the build-test job for --no-default-features and --all-features tests to pass, but building individual packages can still fail.

To make sure this doesn't happen again we should test building each package individually with default, --all-features, and --no-default-features.

Use case

Catch broken feature configurations sooner.
@notmandatory notmandatory moved this to Todo in BDK Wallet Mar 18, 2024
@oleonardolima oleonardolima linked a pull request Aug 26, 2024 that will close this issue
Draft
3 tasks
@oleonardolima
Copy link
Contributor

I gave it a try, and it doesn't seem each package can be built with --no-default-features, at least is not the case for bdk_wallet because of miniscript std/no-std requirement, see https://github.com/bitcoindevkit/bdk/actions/runs/10565729093/job/29270897594?pr=1575

@oleonardolima
Copy link
Contributor

Oh, I guess that's the reason we have the check-no-std job :think:

@notmandatory
Copy link
Member Author

I think we won't be able to fix this issue until rust-bitcoin/rust-miniscript#681 is done.

@oleonardolima oleonardolima mentioned this issue Sep 13, 2024
Merged
6 tasks
@oleonardolima oleonardolima mentioned this issue Oct 2, 2024
Merged
3 tasks
@oleonardolima
Copy link
Contributor

I'll check if the changes from miniscript#681 would unblock this.

@notmandatory notmandatory added the github_actions Pull requests that update GitHub Actions code label Apr 3, 2025
@notmandatory notmandatory transferred this issue from bitcoindevkit/bdk Apr 7, 2025
@oleonardolima
Copy link
Contributor

@notmandatory I think this should be moved back to bitcoindevkit/bdk, as this repository only contains bdk_wallet.

@notmandatory notmandatory transferred this issue from bitcoindevkit/bdk_wallet Apr 21, 2025
@notmandatory notmandatory moved this to Todo in BDK Chain Apr 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
github_actions Pull requests that update GitHub Actions code
Projects
BDK Chain
Status: Todo
BDK Wallet
Status: Todo
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ci: add workspace or single package to build-test oleonardolima/bdk
2 participants
@notmandatory @oleonardolima