iOS browserify

[rubensayshi]

the README says "NOTE: If you expect this library to run on an iOS 10 device, ensure that you are using [email protected] or greater."
I assume that is for the Buffer.prototype.reverse issue that I'm running into, but it doesn't seem to actually fix it ...
also I don't see anything in the buffer package that indicates a fix for the missing reverse method, or was that about Buffer.from?

Uint8Array doesnt have reverse in my iOS emulator.

[dcousens]

https://github.com/feross/buffer/search?q=5.0.5&type=Issues&utf8=%E2%9C%93
feross/buffer#154 (comment)
feross/buffer#155

[rubensayshi]

npm -g ls | grep browserify

├─┬ [email protected]

npm -g ls | grep buffer

│ ├─┬ [email protected]
│ │ │ │ └── [email protected]
│ │ ├── [email protected]
│ │ ├── [email protected]
│ │ └── [email protected]
│ │ │   ├─┬ [email protected]
│ │ │   │ │ │ └── [email protected]
│ │ │   │ ├── [email protected]
│ │ │   │ ├── [email protected]
│ │ │   │ └── [email protected]
│ │ │ │ ├── [email protected]
│ │     │ └── [email protected]
│ │ │ ├── [email protected]
│ │ │ │ ├── [email protected]
│ │ │ │ │ └── [email protected]
│ │ │ │ ├── [email protected]
│ │ │ │   ├─┬ [email protected]
│ │ │ │   │ │ │ └── [email protected]
│ │ │ │   │ ├── [email protected]
npm ERR! peer dep missing: eslint@^3.19.0, required by [email protected]
npm ERR! peer dep missing: eslint-plugin-flowtype@^2.33.0, required by [email protected]
npm ERR! peer dep missing: eslint-plugin-import@^2.2.0, required by [email protected]
npm ERR! peer dep missing: eslint-plugin-jsx-a11y@^5.0.3, required by [email protected]
│ │ │ │ │ ├── [email protected]
│ │ │ │   │ ├── [email protected]
│   │ ├── [email protected]
│   │ └── [email protected]
│ │ │   ├── [email protected]
│ │ │   │ └── [email protected]
│ │ │   │ └── [email protected]
│ │   │ ├── [email protected]
│ │   │ │ └── [email protected]
│ │ ├── [email protected]
│ │ │   │ ├── [email protected]
│ │     │ │ │ │ └── [email protected]
│ │   │     │ ├── [email protected]
│   │   │ ├── [email protected]
│ │ │ │ │ ├── [email protected]
  │ ├── [email protected]
  │ │ ├── [email protected]

// test.js

var b = Buffer.from('00ffee00ffee', 'hex')

alert(b.toString('hex'))
alert(b.reverse().toString('hex'));
alert(typeof b.reverse);

running this on iPhone6 iOS8 and iOS9 simulator fails with reverse being undefined, iOS10 is fine, can't we bring back buffer-reverse? (https://github.com/bitcoinjs/bitcoinjs-lib/compare/master...rubensayshi:bufferreverse?expand=1)

or we dont want to support ios <10 ?

hmm, quickly looking at stats for our app we see 2.4% iOS 9.3 and rest is all 10+

[dcousens]

@rubensayshi I think this is the wrong repository to report this... maybe https://github.com/feross/buffer ?

[rubensayshi]

feross/buffer#167

reported it there, I guess you prefer waiting for a fix there instead of brining back buffer-reverse?

[dcousens]

@rubensayshi ideally yes, if there is such an issue, upstream is the best place to resolve it.
Do you agree?

[dcousens]

@rubensayshi apparently it isn't an upstream thing.
Enforcing buffer-reverse through your stack, is going to be painful.

I think drop iOS<10, re-open if you think otherwise.

[rubensayshi]

I'd strongly prefer bringing back buffer-reverse then ...

from our business perspective ~2% users is too much to ignore for us, as a FOSS project you can be a bit more "focused on the future instead of the past", but the cost is pretty low in this case I think

[dcousens]

@rubensayshi is bitcoinjs-lib the only place to change?

[rubensayshi]

yes, reversing buffers is not something that is done often, if at all ;)

[dcousens]

@rubensayshi PR it up

[dcousens]

@rubensayshi and please submit a safe-buffer PR to https://github.com/crypto-browserify/buffer-reverse

[dcousens]

I too have experienced this on my stack, but I opted to drop the support.
It wans't specifically a bitcoinjs-lib issue, as I had other libraries using Buffer.prototype.reverse too.