Skip to content

Commit 3e6c18c

Browse files
ArthurSonzogniCommit Bot
authored and
Commit Bot
committed
[COEP] Enable on all platforms (e.g. add Android WebView)
There are no real reasons for COEP not to be enforced on Android WebView. See also: [PSA-COEP-expanded-to-webview]: https://groups.google.com/a/chromium.org/g/blink-dev/c/Wc_uYYkcviw [Updated chrome-status entry]: https://chromestatus.com/features/5642721685405696 [original-intent-to-ship-coep]: https://groups.google.com/a/chromium.org/g/blink-dev/c/XBKAGb2_7uA/m/ajpc6_9zAAAJ [crossOriginIsolated spec to be updated]: whatwg/html#6060 Bug: 1140432 Change-Id: I9a7c44671846f20bd0ac2a06b181ed584ad606eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485507 Reviewed-by: Kinuko Yasuda <[email protected]> Reviewed-by: Richard Coles <[email protected]> Reviewed-by: Domenic Denicola <[email protected]> Reviewed-by: Mike West <[email protected]> Commit-Queue: Arthur Sonzogni <[email protected]> Cr-Commit-Position: refs/heads/master@{#820311}
1 parent fc77ffe commit 3e6c18c

File tree

2 files changed

+6
-4
lines changed

2 files changed

+6
-4
lines changed

android_webview/lib/aw_main_delegate.cc

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -240,10 +240,9 @@ bool AwMainDelegate::BasicStartupComplete(int* exit_code) {
240240
// De-jelly is never supported on WebView.
241241
features.EnableIfNotSet(::features::kDisableDeJelly);
242242

243-
// COOP/COEP is not supported on WebView. See:
243+
// COOP is not supported on WebView yet. See:
244244
// https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/XBKAGb2_7uAi.
245245
features.DisableIfNotSet(network::features::kCrossOriginOpenerPolicy);
246-
features.DisableIfNotSet(network::features::kCrossOriginEmbedderPolicy);
247246

248247
features.DisableIfNotSet(::features::kInstalledApp);
249248

services/network/public/cpp/features.cc

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -70,6 +70,7 @@ const base::Feature kProactivelyThrottleLowPriorityRequests{
7070

7171
// Enables Cross-Origin Opener Policy (COOP).
7272
// https://gist.github.com/annevk/6f2dd8c79c77123f39797f6bdac43f3e
73+
// https://html.spec.whatwg.org/#cross-origin-opener-policy
7374
// Currently this feature is enabled for all platforms except WebView.
7475
const base::Feature kCrossOriginOpenerPolicy{"CrossOriginOpenerPolicy",
7576
base::FEATURE_ENABLED_BY_DEFAULT};
@@ -96,8 +97,10 @@ const base::Feature kCrossOriginOpenerPolicyByDefault{
9697
"CrossOriginOpenerPolicyByDefault", base::FEATURE_DISABLED_BY_DEFAULT};
9798

9899
// Enables Cross-Origin Embedder Policy (COEP).
99-
// https://github.com/mikewest/corpp
100-
// Currently this feature is enabled for all platforms except WebView.
100+
// https://html.spec.whatwg.org/#coep
101+
// Currently this feature is enabled for all platforms (including webview).
102+
// TODO(https://crbug.com/1140432): Remove this flag after M88 Stable + 1 week =
103+
// 2021-02-01.
101104
const base::Feature kCrossOriginEmbedderPolicy{
102105
"CrossOriginEmbedderPolicy", base::FEATURE_ENABLED_BY_DEFAULT};
103106

0 commit comments

Comments
 (0)